Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 375457 - [ui] Null pointer exception if a file other than the group file is inserted in the preferences
Summary: [ui] Null pointer exception if a file other than the group file is inserted i...
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-27 14:22 EDT by Jacques Bouthillier CLA
Modified: 2013-01-28 14:05 EST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jacques Bouthillier CLA 2012-03-27 14:22:21 EDT 
In R4E preferences, when the user tries to enter an existing group to the list, he should only be presented with the potential list of group files, not all files having ".xrer".
May be if we filter the files ending with "..._root.xrer", there would be no confusion.

If the user selects any other files, he gets a null pointer exception:
java.lang.NullPointerException
at org.eclipse.mylyn.reviews.r4e.core.model.serial.impl.RModelFactoryExtImpl.openR4EReviewGroup(RModelFactoryExtImpl.java:147)
at org.eclipse.mylyn.reviews.r4e.ui.internal.model.R4EUIModelController.loadReviewGroups(R4EUIModelController.java:340)
at org.eclipse.mylyn.reviews.r4e.ui.internal.model.R4EUIModelController.loadModel(R4EUIModelController.java:304)
at org.eclipse.mylyn.reviews.r4e.ui.internal.navigator.ReviewNavigatorView.getInitalInput(ReviewNavigatorView.java:403)
at org.eclipse.mylyn.reviews.r4e.ui.internal.navigator.ReviewNavigatorView.resetInput(ReviewNavigatorView.java:337)
at org.eclipse.mylyn.reviews.r4e.ui.internal.preferences.R4EPreferencePage.performOk(R4EPreferencePage.java:1017)
at org.eclipse.jface.preference.PreferenceDialog$13.run(PreferenceDialog.java:964)
Comment 1 Jacques Bouthillier CLA 2012-03-27 14:32:41 EDT 
Since there is an invalid file as a group_root file, even if i try to remove it from the list of review group from the preference, it generates a null pointer exception and I cannot enter a new review group
Comment 2 Jacques Bouthillier CLA 2012-03-27 14:42:39 EDT 
As a work around, 
	- you need to remove the R4E navigator view
	- Open the preference dialogue, remove the wrong review group
	- Select OK to apply the new preferences
	- Now you can re-open the R4e navigator view
	- Re-open the preference dialogue
	- Set the appropriate review group and press "Ok"
	--> The new review group is set in the R4E navigator view
Comment 3 Sebastien Dubois CLA 2013-01-28 14:05:40 EST 
This bug was solved in the past but not closed