Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 375355 - XML not valid when job was built from Git
Summary: XML not valid when job was built from Git
Status: RESOLVED FIXED
Alias: None
Product: Hudson
Classification: Technology
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Winston Prakash CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 376370
Blocks:
  Show dependency tree
 
Reported: 2012-03-26 15:03 EDT by Steffen Pingel CLA
Modified: 2012-10-11 00:13 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Pingel CLA 2012-03-26 15:03:27 EDT 
In 3.0.0M1 bug 357679 resurfaced which was fixed as part of http://issues.hudson-ci.org/browse/HUDSON-9002. The XML produced by Hudson is not valid, e.g. http://mylyn.org/hudson-3.0/job/test-git/6/api/xml:

<freeStyleBuild><action><cause><shortDescription>Started by user anonymous</shortDescription><userName>anonymous</userName></cause></action><action><buildsByBranchName><origin/master><buildNumber>6</buildNumber><revision><SHA1>7f940740be763e8a185ecebc06e71e19f87698e6</SHA1><branch><SHA1>7f940740be763e8a185ecebc06e71e19f87698e6</SHA1><name>origin/master</name></branch></revision></origin/master>
...

Notice the <origin/master> tag where the slash is not escaped properly.
Comment 1 Steffen Pingel CLA 2012-04-09 15:24:25 EDT 
Winston, do you have any pointers where we could start looking to get this fixed?
Comment 2 Winston Prakash CLA 2012-04-09 20:59:22 EDT 
Steffen, In order to fix this issue in Hudson 2.1.2 we switched to Stapler version later that 1.155. In Hudson 3.0.0-M1 we switched back to Stapler version 1.155 due to some IP issues. I found the changes associated with fixing this issue. 

If you show me an example how to create a Hudson job that has this issue, then I can verify my fix and check in the code.
Comment 3 Steffen Pingel CLA 2012-04-09 21:10:32 EDT 
It should be reproducible with any job that is triggered by a Git commit. I saw this with the job from the EclipseCon Hudson tutorial for instance. If you have a war then I can easily deploy that to our test server to verify the fix, too.
Comment 5 Steffen Pingel CLA 2012-04-13 01:37:59 EDT 
This looks good! http://mylyn.org/hudson-3.0/job/test-git/6/api/xml now produces proper XML and the Mylyn tests are passing. Thanks!
Comment 6 Winston Prakash CLA 2012-10-11 00:13:00 EDT 
Fixed in M2