Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 375152 - A outline search cancel should be visible for the user
Summary: A outline search cancel should be visible for the user
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Scout (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-23 05:27 EDT by Stephan Merkli CLA
Modified: 2021-08-19 11:06 EDT (History)
2 users (show)

See Also:
zimmermann: indigo+
zimmermann: juno+


Attachments
Patch according to proposed solution (1.96 KB, patch)
2012-03-23 06:13 EDT, Stephan Merkli CLA
andi.bur: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Merkli CLA 2012-03-23 05:27:16 EDT
Build Identifier: M20110210-1200

When a user cancels the search in an outline, the search form keeps its state but the displayed rows belong to the last executed search.

Proposal: if a user cancels the search, all rows in the table should be discarded and the user show be notified of the canceled search.

Reproducible: Always

Steps to Reproduce:
1. Search in an outline
2. Results are displayed
3. Use a search that takes a while
4. Execute & cancel the search
5. Result of last search is still displayed but the search form shows the new search constraints
Comment 1 Matthias Zimmermann CLA 2012-03-23 05:53:40 EDT
I'm not (yet) convinced that this is a sound proposal. Before we continue, please explain away the following two options:

(1) this is not a framework issue. let the application decide and implement the desired behaviour

(2) reset the search form to the previous state (so it matches the tables content)

There might be also other options
Comment 2 Stephan Merkli CLA 2012-03-23 06:13:34 EDT
Created attachment 213098 [details]
Patch according to proposed solution
Comment 3 Stephan Merkli CLA 2012-03-23 06:17:58 EDT
The option 2 would somehow violate the existing behaviour. If e.g. a form cannot be stored (VetoException), it's not just closed, it's kept open. 

In case of a search, the user might have spend several minutes creating a search (advanced search) and just forgot to add an addtional constraint. Thus it would not be a proper solution to just restore the last state, because the user would need to start again specifying the search constraints.
Comment 4 Andi Bur CLA 2012-03-26 11:27:59 EDT
o If a user cancels the search, all rows in the table are discarded and the user is notified about the canceled search.
  
o Additionally, any exception during loading the table data behaves the same: the table data is discarded and the table status is set appropriately.
  
o If the severity of the table population status is IProcessingStatus.CANCEL, the table selection status is hidden and the population status is rendered like a warning (e.g. foreground color orange).
Comment 5 Andi Bur CLA 2012-03-26 11:30:37 EDT
Used Stephan's patch as working base. Thank you for the contribution.
Comment 6 Matthias Zimmermann CLA 2013-07-08 17:36:34 EDT
Bugfixes shipped on Scout 3.7 branch