Community
Participate
Working Groups
A user should be able to specify a ContextQuery filter for a given BP via the UI.
Created attachment 212833 [details] proposed patch This is the first in a series of user stories which define a workflow for a user to set filters for breakpoints. This patch covers US3233 and US2644. These are basic functional stories which will be enhanced with user stories to follow.
Incase the previously sited user stories cannot be retrieved, the sumary for these are: Persist a context scoped breakpoint across debug sessions. As an AMP systems developer, I want to scope a breakpoint to a specific core name, and have it persist accross multiple debug sessions. As I re-launch my debug session multiple times (including disconnect/reconnect ; recompile source and reload etc), I expect the breakpoint properties to persist such that I continue getting the same debug experience.
Created attachment 212896 [details] Updated patch This updated patch adds basic expression format checking.
Created attachment 212934 [details] proposed patch One last update, to alter the workflow of the expression parameter selection dialog. This allows a user to build an expression.
Created attachment 212968 [details] Patch to coincide with bug 373278. Patch which is merged with the changes to bug 373278, and so should only be referenced if 373278 is incorporated first. If this is not the case, the last proposed patch should be referenced.
Created attachment 213537 [details] proposed patch
(In reply to comment #6) > Created attachment 213537 [details] > proposed patch I'm getting assertion failures when I try to test the patch: java.lang.AssertionError at org.eclipse.tcf.core.AbstractChannel.getRemoteService(AbstractChannel.java:740) at org.eclipse.tcf.internal.cdt.ui.breakpoints.TCFThreadFilterEditor.getAvailableAttributes(TCFThreadFilterEditor.java:369) at org.eclipse.tcf.internal.cdt.ui.breakpoints.TCFThreadFilterEditor.access$11(TCFThreadFilterEditor.java:363) at org.eclipse.tcf.internal.cdt.ui.breakpoints.TCFThreadFilterEditor$ExpressionSelectButton.handleEvent(TCFThreadFilterEditor.java:452) at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84) ... Could you, please, re-test it with asserts enabled (-ea), fix failures and re-submit the patch?
Created attachment 213687 [details] proposed patch Sorry about that! I've corrected the assert, did a quick review for other potential issues like this, and retested. The attached no longer throws any assert when testing the workflows.
I have committed the patch. Thanks!
Comment on attachment 213687 [details] proposed patch iplog- since git has the author: http://git.eclipse.org/c/tcf/org.eclipse.tcf.git/commit?id=07fd3cb8c028dba668ee4905f76b3a024d950e75
