This Bugzilla instance is deprecated, and most Eclipse projects now use GitHub or Eclipse GitLab. Please see the deprecation plan for details.
Bug 374310 - [MinMax] Closing the last perspective in a minimized perspective stack leaves the model in a strange state
Summary: [MinMax] Closing the last perspective in a minimized perspective stack leaves...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 4.4 M6   Edit
Assignee: Daniel Rolka CLA
QA Contact:
URL:
Whiteboard: candidate43
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-14 16:28 EDT by Eric Moffatt CLA
Modified: 2014-03-04 05:33 EST (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Moffatt CLA 2012-03-14 16:28:30 EDT
Start a fresh workspace (or use an existing one and open Welcome)
Close the perspective

1) the Welcome goes away (this may well be platform behavior considering that in 3.x the Welcome view is really inside a perspective)

2) subsequently opening a new perspective shows that the model is in a corrupt state...
Comment 1 Nobody - feel free to take it CLA 2014-02-03 07:40:22 EST
I took a stab at this.

In WorkbenchPage line 3967 (!) we set the perspective to take the leftmost 75% and the welcomepage (or StickyFolderRight) to the other 25%. So upon closing the perspective the sticky folder, which is out of the perspective and a direct child of the window, goes to it's 25% on the right. When you open the next perspective it stays there on its own 25% until you close it. 

So I'm not sure of the erratic behavior here. Maybe it's in the moment when you close the perspective and it goes to the rightmost position? Would this be a corrupt state.

Can forced minimizing of other non-perspective elements be a way to go for this case?

Working with : N20140130-2000
Comment 2 Daniel Rolka CLA 2014-02-05 06:06:15 EST
The patch proposal: https://git.eclipse.org/r/#/c/21553/

Daniel
Comment 3 Eric Moffatt CLA 2014-02-05 11:19:57 EST
Daniel, thanks for the patch, it works fine...but...because of changes I committed yesterday for Bug 377085 I've updated the patch and re-submitted it to Gerrit. The fix I did was to auto-unmax any maxmimized element if there are no more elements minimized by the 'zoom' of the currently maximized element. This is a general fix and includes (indirectly) the same code as your patch; unmaximizing the Welcome stack.

Please take a look at the revised patch and get back if you have questions...
Comment 4 Daniel Rolka CLA 2014-02-06 06:13:59 EST
(In reply to Eric Moffatt from comment #3)
> Daniel, thanks for the patch, it works fine...but...because of changes I
> committed yesterday for Bug 377085 I've updated the patch and re-submitted
> it to Gerrit. The fix I did was to auto-unmax any maxmimized element if
> there are no more elements minimized by the 'zoom' of the currently
> maximized element. This is a general fix and includes (indirectly) the same
> code as your patch; unmaximizing the Welcome stack.
> 
> Please take a look at the revised patch and get back if you have questions...

The updated patch works fine for me. I've pushed it to master

Daniel
Comment 6 Daniel Rolka CLA 2014-03-04 05:33:00 EST
Verified in the build: I20140303-2000

Daniel