Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 374022 - SapphireDiagramEditor does not initialize page part with SapphireEditor parent
Summary: SapphireDiagramEditor does not initialize page part with SapphireEditor parent
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Sapphire (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Shenxue Zhou CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-12 21:38 EDT by Greg Amerson CLA
Modified: 2021-11-19 09:22 EST (History)
1 user (show)

See Also:

Attachments
Patch v1 (6.27 KB, patch)
2012-03-12 21:43 EDT, Greg Amerson CLA 		no flags Details | Diff
Patch v2 (8.69 KB, patch)
2012-03-12 22:53 EDT, Greg Amerson CLA 		no flags Details | Diff
Patch v3 (9.25 KB, patch)
2012-03-12 23:03 EDT, Greg Amerson CLA 		konstantin: iplog+
Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Amerson CLA 2012-03-12 21:38:24 EDT 
The problem is that SapphireDiagramEditor fails to pass in parent part (SapphireEditor) when initializing SapphireDiagramEditorPagePart on line 120 as contrasted with line 230 in MasterDetailsEditorPage where this is done correctly. Fixing this issue will make the IEditorSite adapt usecase work.
Comment 1 Greg Amerson CLA 2012-03-12 21:43:04 EDT 
Created attachment 212515 [details]
Patch v1
Comment 2 Konstantin Komissarchik CLA 2012-03-12 22:09:08 EDT 
It looks like an entry in the migration guide will be required for this...
Comment 3 Konstantin Komissarchik CLA 2012-03-12 22:13:18 EDT 
A migration guide node for this should go into the section covering Graphiti to GEF transition, since its a different SapphireDiagramEditor class going from 0.4 to 0.5 release.
Comment 4 Greg Amerson CLA 2012-03-12 22:53:58 EDT 
Created attachment 212516 [details]
Patch v2

This version adds stubbed out sections for migration guide.  Looks like more will need to be added to cover everything related to bug 344228
Comment 5 Greg Amerson CLA 2012-03-12 23:03:51 EDT 
Created attachment 212517 [details]
Patch v3

Updated documentation to include the removal of need for explicit SapphireDiagramEditorInput creation.
Comment 6 Shenxue Zhou CLA 2012-03-13 12:10:05 EDT 
Patch has been reviewed and submitted. Thanks Greg!
Comment 7 Konstantin Komissarchik CLA 2012-03-13 15:00:16 EDT 
Comment on attachment 212517 [details]
Patch v3

Please make sure to remember to set the iplog flag when accepting a patch.
Comment 8 Konstantin Komissarchik CLA 2012-03-13 15:01:59 EDT 
Greg, could you verify?
Comment 9 Greg Amerson CLA 2012-03-13 21:57:33 EDT 
Verified with build 0.5.x #131  Thanks.
Comment 10 Konstantin Komissarchik CLA 2012-03-13 22:23:02 EDT 
Thanks. Closing.