Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 372873 - Duplicate 'Plug-in Development' entries in Customize perspective dialog
Summary: Duplicate 'Plug-in Development' entries in Customize perspective dialog
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.8   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.2 M6   Edit
Assignee: Michael Rennie CLA
QA Contact: Eric Moffatt CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-29 11:43 EST by Michael Rennie CLA
Modified: 2012-02-29 14:50 EST (History)
3 users (show)

See Also:


Attachments
screen shot (54.85 KB, image/png)
2012-02-29 11:43 EST, Michael Rennie CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2012-02-29 11:43:17 EST
Created attachment 211816 [details]
screen shot

Version: 4.2.0
Build id: I20120223-2200

Steps:

1. Open the Customize perspective dialog
2. go to the 'Shortcuts' tab
3. select 'Show View' from the Submenus option
4. notice there are two Plug-in Development entries - one has content the other does not, and you cannot check the empty one

See attached screen shot
Comment 1 Michael Rennie CLA 2012-02-29 12:27:40 EST
looks like the problem comes from the fact that PDE defines the same category twice: once in pde.runtime and once in pde.ui. I would expect the categories to be combined if this is the case.

Looking at the code from the ViewRegistry class it looks like even if N categories with the same id are defined searching for that id will always only return the first match (see #findCategory).

If I change the field 'categories' to be a map so we don't save duplicate category descriptions the problem goes away.

I pushed the map fix to my github branch:

https://github.com/mrennie/eclipse.platform.ui/tree/mrennie/bug372873
Comment 2 Eric Moffatt CLA 2012-02-29 14:28:30 EST
Pushed in >20120229.

commit bb6f39309398233efcc020958a4eb1ce8792cd02

Nice one Mike !