Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 372724 - [Model Explorer] Search function does not traverse EReferences, LinkItems
Summary: [Model Explorer] Search function does not traverse EReferences, LinkItems
Status: RESOLVED FIXED
Alias: None
Product: Papyrus
Classification: Modeling
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Tristan Faure CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-28 07:14 EST by Philippe Roland CLA
Modified: 2012-03-28 05:17 EDT (History)
1 user (show)

See Also:


Attachments
Proposed patch for branch 0.8.X (29.93 KB, patch)
2012-02-28 07:35 EST, Philippe Roland CLA
rschnekenburger: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Roland CLA 2012-02-28 07:14:26 EST
Build Identifier: Version: 3.7.1 Build id: M20110909-1335

The search function as currently implemented does not traverse EReferences and LinkItems. This means that some tree items (for instance, a Class' ownedAttributes) cannot be found.  

The comitted solution involves:
*A change to the NavigatorSearchDialog pattern search algorithm, allowing traversal of problematic elements: this is done using an Adapter mechanism so additional components contributing to the Model Explorer can easily extend it.
*A change to CustomCommonViewer and ModelExplorerView's reveal methods' matching algorithm, with a complete MatchingItem refactoring. This overhaul includes the creation of an IReferencable interface exposing a getElementBehind() method, which additional components can implement to declare their own match logic

Reproducible: Always

Steps to Reproduce:
1.Create a Papyrus UML model with a Class and a Property belonging to that Class.
2.Use the search dialog to find that property.
3.The property cannot be found.
Comment 1 Philippe Roland CLA 2012-02-28 07:35:41 EST
Created attachment 211721 [details]
Proposed patch for branch 0.8.X

See comment above.
Comment 2 Philippe Roland CLA 2012-02-28 07:47:41 EST
Comment on attachment 211721 [details]
Proposed patch for branch 0.8.X

I, Philippe Roland, have written 100% of the code contributed to fix this bug.
I have the right to contribute this code and have filled the headers with the
appropriate License.
This contribution has been checked by and committed under the responsability of
Tristan Faure
Comment 3 Tristan Faure CLA 2012-02-28 07:56:15 EST
commited on the branch
Comment 4 Tristan Faure CLA 2012-02-28 08:38:15 EST
backported to the trunk