Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 372542 - Unfocused stack's tab feels under decorated
Summary: Unfocused stack's tab feels under decorated
Status: CLOSED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-UI-Inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-24 15:07 EST by Wayne Beaton CLA
Modified: 2019-11-14 03:43 EST (History)
7 users (show)

See Also:


Attachments
Unfocused view stack (8.43 KB, image/png)
2012-02-24 15:10 EST, Wayne Beaton CLA
no flags Details
Inactive stack with keyline specified (5.76 KB, image/png)
2012-02-24 20:49 EST, Wayne Beaton CLA
no flags Details
Unfocused tab treatment (1.31 MB, image/bmp)
2012-02-29 18:12 EST, Bogdan Gheorghe CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Wayne Beaton CLA 2012-02-24 15:07:04 EST
I'm running Fedora 14.

When the stack loses focus, the trim becomes very plain and the tab feels underdecorated to me.

I like the light border on the unfocused stack, but the border around the top item's tab and the background colour of the tool items (Bug 372539) makes for an abrupt change. 

I'll attach a screenshot.
Comment 1 Wayne Beaton CLA 2012-02-24 15:10:26 EST
Created attachment 211608 [details]
Unfocused view stack

I really like the light trim, right up to the point where it meets the tab border in the top-left. The switch from no line to line makes the stack look odd. Maybe a lighter border all around will do the trick...

(FWIW, I'm not *just* complaining, I'll see if I can hack together some alternatives).
Comment 2 Wayne Beaton CLA 2012-02-24 20:49:12 EST
Created attachment 211618 [details]
Inactive stack with keyline specified

Just adding trim to the basic stack make it look better. Here are the changes to the CSS:

.MPartStack {
	...
    outer-keyline-color: #B4B4B4;
}

.MPartStack.active {
	unselected-tabs-color: #DCDCDC #E1E1E1 #FFFFFF 100% 100%;
   // outer-keyline-color: #B4B4B4;
    tab-outline: #B4B4B4;
}

i.e. don't change the outline-keyline-color when we go active. Just set it and keep it.

Thoughts?
Comment 3 Bogdan Gheorghe CLA 2012-02-29 18:12:15 EST
Created attachment 211849 [details]
Unfocused tab treatment

The initial idea was to keep it completely minimal and have no lines at all but that got some negative feedback in that it was hard to see what was last active in  a stack. Our designer suggested this look for unfocused tabs. What do you think?
Comment 4 Wayne Beaton CLA 2012-02-29 21:45:31 EST
(In reply to comment #3)
> Created attachment 211849 [details]
> Unfocused tab treatment
> 
> The initial idea was to keep it completely minimal and have no lines at all but
> that got some negative feedback in that it was hard to see what was last active
> in  a stack. Our designer suggested this look for unfocused tabs. What do you
> think?

+1
Comment 5 Deepak Azad CLA 2012-03-01 06:44:17 EST
(In reply to comment #3)
+1. That could work.
Comment 6 Bogdan Gheorghe CLA 2012-03-12 17:15:11 EDT
I took a stab at this today - check it out in tonight's build. The final gradient should probably be controlled through CSS...
Comment 7 Lars Vogel CLA 2019-11-14 03:43:25 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

If the bug is still relevant, please remove the "stalebug" whiteboard tag.