Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 372272 - admin user list page - glue code is not setting up the selection service.
Summary: admin user list page - glue code is not setting up the selection service.
Status: CLOSED INVALID
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.4   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-22 14:12 EST by Susan McCourt CLA
Modified: 2014-09-12 09:02 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2012-02-22 14:12:02 EST
In reviewing bug 372262 I noticed that we pass "null" as the selections when we render commands to the "More" menu in the user list page.

If no selections or item are passed in to the command service on render, then the selection service will be consulted.  The navigator uses this same technique with the more menu.

However, the navigator is setting up a selection service in the command service.  That allows the "null" behavior to work properly.

The glue code for the user list is not doing so, so there will never be any commands rendered on that first call to updateNavTools.

Compare users.ui/web/profile/user-list.js    line 25, 27  (wrong way)

to

client.core/web/navigate/table.js   line 26, 33 (right way)

What this means is that the page will never render selection based commands until the selections change in some way.  So behavior like "remembering previously selected items when you page back in history" will not work.
Comment 1 Susan McCourt CLA 2012-02-22 14:17:00 EST
(In reply to comment #0)
> What this means is that the page will never render selection based commands
> until the selections change in some way.  So behavior like "remembering
> previously selected items when you page back in history" will not work.

Well, it's more specific than that.
"remembering previously selected items" may not be implemented on this page, would have to investigate this further.  This bug as stated simply means that the first time you render commands (not because of a selection service notification), you won't get the selection based command such as "Delete User" even if there were a selection known by the service.

Only when the selection changes would the toolbar be updated.

But the reality is that you probably always get a notification from the service, because even persisted selections trigger callbacks.
Comment 2 Susan McCourt CLA 2013-02-14 14:12:41 EST
This bug refers to a coding error I noticed, but I'm not sure there's even a symptom.  It's just about properly instantiating the services for a page.  Not a 2.0 RC2 issue.  Removing milestone.
Comment 3 Malgorzata Janczarska CLA 2014-09-12 09:02:25 EDT
I think we don't have this page any more.