Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 372243 - Facet extending EObject to provide eClass(), eContainer(), etc.
Summary: Facet extending EObject to provide eClass(), eContainer(), etc.
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EMF-Facet (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P2 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Gregoire Dupe CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-22 10:28 EST by Gregoire Dupe CLA
Modified: 2020-05-01 11:26 EDT (History)
2 users (show)

See Also:
gdupe: juno+

Attachments
org.eclipse.emf.facet.ecore plug-in (15.03 KB, application/zip)
2012-02-22 10:41 EST, Gregoire Dupe CLA 		gdupe: iplog+
Details
This patch provides the a Facet to replace the LabelColumn in the table (2.61 KB, patch)
2012-02-27 09:03 EST, Vincent Lorenzo CLA 		gdupe: review-
Details | Diff
This patch provides the self column (used for [Label] for example). + add the attribute changeable="false" to the other facets (3.84 KB, patch)
2012-02-28 11:00 EST, Vincent Lorenzo CLA 		gdupe: iplog+
gdupe: review+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gregoire Dupe CLA 2012-02-22 10:28:58 EST 
We need a facet extending EObject to provide eClass(), eContainer(), etc.

This facet will be used by the table and the customizable content provider.
Comment 1 Gregoire Dupe CLA 2012-02-22 10:41:54 EST 
Created attachment 211416 [details]
org.eclipse.emf.facet.ecore plug-in

Here is a plug-in containing the required facet.

(a) I, Gregoire Dupe, wrote 100% of the code I've provided.
(b) I have the right to contribute the code to Eclipse.
(c) I contribute the content under the EPL.
(d) This contribution contains no Cryptography features.
Comment 2 Gregoire Dupe CLA 2012-02-22 10:44:18 EST 
Comment on attachment 211416 [details]
org.eclipse.emf.facet.ecore plug-in

I've committed the new plug-in.
Comment 3 Gregoire Dupe CLA 2012-02-22 10:44:59 EST 
The bug can be marked has fixed.
Comment 4 Vincent Lorenzo CLA 2012-02-27 09:03:37 EST 
Created attachment 211665 [details]
This patch provides the a Facet to replace the LabelColumn in the table

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.
Comment 5 Gregoire Dupe CLA 2012-02-28 05:05:17 EST 
Comment on attachment 211665 [details]
This patch provides the a Facet to replace the LabelColumn in the table

The label query already exits in the customization component: org.eclipse.emf.facet.custom.ui.internal.query.LabelQuery.

The facetOperation 'commoncustomproperties::CustomizedEObject::label()' must be used. Using the parameter facetManager of the method org.eclipse.emf.facet.query.java.core.IJavaQuery2.evaluate(T, IParameterValueList2, IFacetManager).
Comment 6 Vincent Lorenzo CLA 2012-02-28 11:00:32 EST 
Created attachment 211739 [details]
This patch provides the self column (used for [Label] for example). + add the attribute changeable="false" to the other facets

(1) I, Vincent Lorenzo, wrote 100% of the code I've provided.
(2) This code contains no cryptography
(3) I have the right to contribute the code to Eclipse.
(4) I contribute the content under the EPL.
Comment 7 Gregoire Dupe CLA 2012-03-01 08:01:13 EST 
Comment on attachment 211739 [details]
This patch provides the self column (used for [Label] for example). + add the attribute changeable="false" to the other facets

This patch is smaller than 250 lines (36 lines). I've then committed this patch.

 Committed revision 1691.
Comment 8 Gregoire Dupe CLA 2012-05-23 06:33:36 EDT 
This bug can be closed.