Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 372077 - Context debug view not plumbed in properly
Summary: Context debug view not plumbed in properly
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 4.2 M6   Edit
Assignee: Oleg Besedin CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-20 18:56 EST by Brian de Alwis CLA
Modified: 2012-03-13 14:29 EDT (History)
3 users (show)

See Also:

Attachments
Patch to the context debugger (5.99 KB, patch)
2012-02-21 15:20 EST, Brian de Alwis CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian de Alwis CLA 2012-02-20 18:56:19 EST 
org.eclipse.e4.core.contexts.debug provides a nifty context debug view.  But it is not accessible from the E3.x compat layer.  Although it adds itself to the MApplication's part descriptors, the IViewRegistry provided to Show View dialog (org.eclipse.ui.internal.dialogs.ShowViewDialog) does not actually include the MApplication's part descriptor list.
Comment 1 Remy Suen CLA 2012-02-20 20:08:11 EST 
Without writing your own code, the only way to open it right now is to use Ctrl+3.
Comment 2 Brian de Alwis CLA 2012-02-21 15:20:23 EST 
Created attachment 211362 [details]
Patch to the context debugger

Fix up the context debug view:

  * Modify plugin.xml to add the ContextTraceLegacyView: the processor approach doesn't work due to bug 323506: pure E4 parts are not usable as Eclipse workbench parts.

  * Fix up ContextTraceLegacyView to use the context to create and inject the internal class

  * Change FindTargetAction to use an event filter as setCapture() doesn't work on MacOS X

Oleg, can you verify?  I wonder if this shouldn't be moved to the e4 Tools...
Comment 3 Oleg Besedin CLA 2012-02-22 16:36:05 EST 
Thanks Brian!

Patch applied to Git master:

http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=586f49b788803e509ec0e04368d036017f83bd82
Comment 4 Oleg Besedin CLA 2012-03-13 14:29:13 EDT 
Verified using I20120313-0610.