Community
Participate
Working Groups
I accidentally got myself into the "Default" theme on the Appearance preference page. On the next restart I discovered that it looks hideous. There are extra black lines all over the place, and some huge margin padding between toolbar and view/editor panes. We should either make this pretty or remove it, and in its current state it shouldn't be called "Default".
Created attachment 211120 [details] Screen shot
+1 from me, we should either remove it or fix it (and removing it is easier...;-). BTW I also get a couple of errors in the console... java.io.FileNotFoundException: .\winXPBlue.PNG (The system cannot find the file specified) not sure what's up with that...
If we remove it, we need to make sure that if people start an old (including 3.x) workspace with default appearance get redirected to some existing theme.
> I accidentally got myself into the "Default" theme on the Appearance preference page. > How hard is it to make that happen? Does switching to other themes trash the appearance? Should we be removing the whole theming preference page? (Actually, I thought we already had)
*** Bug 349867 has been marked as a duplicate of this bug. ***
Moving to RC1...
Created attachment 225018 [details] Classic theme on Linux Honestly there isn't much choices on Linux: "Default" is utterly broken as described by John, "Gnome" isn't much better in terms of look and feel (the only vertical padding is not so huge and blue color is replaced to gray), and the only usable "Classic" has some cheese and pixel artifacts and ... mru editor tabs order. I will attach pictures of each theme on my Kubuntu 12.10. So from professional point of view only "Classic" looks nice (beside few pixel artifacts). Regarding removal of themes selection - why? Shouldn't at least some 3rd party developers be able to provide new (usable) themes?
Created attachment 225019 [details] Default theme on Linux
Created attachment 225020 [details] Gnome theme on Linux
I would defer this to 4.3.
Yes, we are in the 4.2.2 end-game now.
Too late for Kepler.
(In reply to Dani Megert from comment #3) > If we remove it, we need to make sure that if people start an old (including > 3.x) workspace with default appearance get redirected to some existing theme. I set the theme to 'Default', then deleted it and restarted. The workspace simply switched to 'Windows 7' without any complaint. I also looked for "default.noos" in the code base and found no reference. Paul, Erich, any idea whether this could be used elsewhere?
> I set the theme to 'Default', then deleted it and restarted. The workspace > simply switched to 'Windows 7' without any complaint. I also looked for > "default.noos" in the code base and found no reference. Same here, removing the default theme is handled well. And it is not referred in the eclipse.platform or eclipse.platform.ui repository. [Search via: grep -r "e4_default.css" .] I think we are save to remove the theme.
https://git.eclipse.org/r/#/c/18011/1
Thanks for merging Dani. Fixed with https://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=c61f9ab80a8154f39c4132065ca5db0486250155
(In reply to Lars Vogel from comment #16) > Thanks for merging Dani. Fixed with > https://git.eclipse.org/c/platform/eclipse.platform.git/commit/ > ?id=c61f9ab80a8154f39c4132065ca5db0486250155 np, though I already had the change in my workspace ;-). I removed the no longer used NLS key from 'plugin.properties' with http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=7e778643de3f337f796617b5239cf994e3aa5754
*** Bug 421387 has been marked as a duplicate of this bug. ***
Verified in Build id: I20131211-2000 #YEAH!
