Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 371606 - [EMF Compare] Papyrus should provide a nested editor to compare 2 elements included in the same resource
Summary: [EMF Compare] Papyrus should provide a nested editor to compare 2 elements in...
Status: CLOSED WONTFIX
Alias: None
Product: Papyrus
Classification: Modeling
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Vincent Lorenzo CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 376260 377143 377154 377189 385726 385946 386042
Blocks: 330183
  Show dependency tree
 
Reported: 2012-02-15 06:08 EST by Vincent Lorenzo CLA
Modified: 2016-03-10 06:51 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vincent Lorenzo CLA 2012-02-15 06:08:23 EST
Currently, when you use the compare action between 2 element provided by the ModelExplorer, this action opens a new CompareEditor. It is not a correct behavior for several reason : 
	- we are comparing elements of the model, so we should stay in the PapyrusEditor to do the comparison
	- if we open a new editor, we should use a new EditingDomain, it will be a problem because the edited EObject are already owned by the PapyrusEditingDomain
	- it don't will correct to use the same EditingDomain in 2 Eclipse Editors

	For these reasons, Papyrus should provides a nested CompareEditor to do this action.

Which should be the behavior of this editor ? 
	- persistent : like Diagram and Table -> I think it is not the correct behavior, the compare action is not a representation of the model.
	- volatile : not visible in the ModelExplorer, in the HyperLinkShellEditor aso..., 
			when you close it, it disappears
			when you close Papyrus or Eclipse, it disappears too.
	- a 3rd behavior should be possible : 
			when you close if, it disappears, but it is stored when you close Papyrus or Eclipse, that is to say, this editor 
is always here when you re-open Papyrus.
Comment 1 Vincent Lorenzo CLA 2012-02-17 04:17:09 EST
In R7215 : share the new plugin oep.infra.emf.compare.instance on the SVN. 
This plugin provides the model for the content of the CompareEditor.
Comment 2 Vincent Lorenzo CLA 2012-04-06 13:07:57 EDT
In R7766 : 
  commit changes on : 
  	- oep.infra.emf.compare.common
  	- oep.infra.emf.compare.ui
  	- oep.papyrus.uml.compare
  	
 -> open Compare as embedded editor in Papyrus
 -> Synchronize its tabs name with : 
 			- name change on one of the compared element
 			- customization change for the editor
 -> correct some bugs using EditorUtil.getActiveDiagram : 
 		- at the beginning we sometimes we get the PapyrusCoreDiagram -> corrected
 			-> warning, GetDiffElementLabel is called too early (when the new editor is not yet opened, so 
 we use the bad LabelProvider during the opening of the editor -> corrected during the setFocus of the editor
Comment 3 Vincent Lorenzo CLA 2012-04-18 09:32:55 EDT
In R7918 : 
UML Compare File  : now inherits from EMFCompareEditor
Nested Compare Editor : corrects the contents displayed content merger viewers : 
	we don't display the full resource, but only the compared elements
Comment 4 Vincent Lorenzo CLA 2012-04-19 09:51:16 EDT
In R7943 : assure that the Nested UML Compare Editor is removed from the resource when we close it. (Done By CloseEditorTriggerListener)
Comment 5 Vincent Lorenzo CLA 2012-06-13 12:07:35 EDT
R8303 : Commit the test plugin oep.uml.compare.tests
Comment 6 Vincent Lorenzo CLA 2012-06-29 06:02:05 EDT
(In reply to comment #4)
> In R7943 : assure that the Nested UML Compare Editor is removed from the
> resource when we close it. (Done By CloseEditorTriggerListener)

We should write a test for that
Comment 7 Vincent Lorenzo CLA 2016-03-10 06:51:39 EST
We abandonned this feature. I close the bug