Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 371285 - Session comparison between runs
Summary: Session comparison between runs
Status: RESOLVED FIXED
Alias: None
Product: Linux Tools
Classification: Tools
Component: perf (show other bugs)
Version: 1.2.1   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 2.0   Edit
Assignee: Roland Grunberg CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-10 15:26 EST by Roland Grunberg CLA
Modified: 2014-08-20 15:04 EDT (History)
3 users (show)

See Also:


Attachments
Added PMSymbolMatch class (4.66 KB, patch)
2012-06-22 18:32 EDT, Camilo Bernal CLA
jjohnstn: iplog+
Details | Diff
Added PerfDefaultLaunchConfiguration class (3.17 KB, patch)
2012-06-22 18:33 EDT, Camilo Bernal CLA
no flags Details | Diff
Added PMSymbolMatcher class (5.08 KB, patch)
2012-06-22 18:34 EDT, Camilo Bernal CLA
no flags Details | Diff
Added data file collection/clear actions (4.70 KB, patch)
2012-06-22 18:35 EDT, Camilo Bernal CLA
jjohnstn: iplog+
Details | Diff
Added data collection viewer (5.17 KB, patch)
2012-06-22 18:35 EDT, Camilo Bernal CLA
jjohnstn: iplog+
Details | Diff
Added data comparison viewer (5.21 KB, patch)
2012-06-22 18:36 EDT, Camilo Bernal CLA
jjohnstn: iplog+
Details | Diff
Added label provider and column sorter to the compaison viewer (7.03 KB, patch)
2012-06-22 18:38 EDT, Camilo Bernal CLA
jjohnstn: iplog+
Details | Diff
Added data comparison action (4.28 KB, patch)
2012-06-22 18:38 EDT, Camilo Bernal CLA
jjohnstn: iplog+
Details | Diff
Modified perf viewer and plug-in.xml (2.66 KB, patch)
2012-06-22 18:41 EDT, Camilo Bernal CLA
no flags Details | Diff
Added copyright header to PMSymbolMatcher class (5.60 KB, patch)
2012-06-22 19:44 EDT, Camilo Bernal CLA
jjohnstn: iplog+
Details | Diff
Added project name to configuration attributes (3.43 KB, patch)
2012-06-28 10:21 EDT, Camilo Bernal CLA
jjohnstn: iplog+
Details | Diff
Updated patch to reflect current changes on master. (2.74 KB, patch)
2012-06-28 16:33 EDT, Camilo Bernal CLA
jjohnstn: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Roland Grunberg CLA 2012-02-10 15:26:29 EST
In the future, it would be nice to have the ability to compare results of profiling the same binary. For example, in the simple case, suppose a user made a change to some method and wanted to test how the new change affected performance. They could run one session before the change, and one after. They could then specify that they want the 2 sessions to be compared and displayed in an easy to understand format. The work for this functionality in Eclipse OProfile existed in a branch in our old svn repos, and it shouldn't be too difficult to adapt this to work for perf.
Comment 1 Camilo Bernal CLA 2012-06-22 18:32:53 EDT
Created attachment 217768 [details]
Added PMSymbolMatch class
Comment 2 Camilo Bernal CLA 2012-06-22 18:33:51 EDT
Created attachment 217769 [details]
Added PerfDefaultLaunchConfiguration class
Comment 3 Camilo Bernal CLA 2012-06-22 18:34:24 EDT
Created attachment 217770 [details]
Added PMSymbolMatcher class
Comment 4 Camilo Bernal CLA 2012-06-22 18:35:09 EDT
Created attachment 217771 [details]
Added data file collection/clear actions
Comment 5 Camilo Bernal CLA 2012-06-22 18:35:51 EDT
Created attachment 217772 [details]
Added data collection viewer
Comment 6 Camilo Bernal CLA 2012-06-22 18:36:49 EDT
Created attachment 217773 [details]
Added data comparison viewer
Comment 7 Camilo Bernal CLA 2012-06-22 18:38:28 EDT
Created attachment 217774 [details]
Added label provider and column sorter to the compaison viewer
Comment 8 Camilo Bernal CLA 2012-06-22 18:38:57 EDT
Created attachment 217775 [details]
Added data comparison action
Comment 9 Camilo Bernal CLA 2012-06-22 18:41:18 EDT
Created attachment 217776 [details]
Modified perf viewer and plug-in.xml

Modified perf viewer and plug-in.xml to include the data collection/comparison view.
--

I submitted this patch, with the permission of my employer,  under
the epl license agreement and is written entirely by me.
Comment 10 Camilo Bernal CLA 2012-06-22 19:44:01 EDT
Created attachment 217779 [details]
Added copyright header to PMSymbolMatcher class
Comment 11 Camilo Bernal CLA 2012-06-28 10:21:09 EDT
Created attachment 218026 [details]
Added project name to configuration attributes
Comment 12 Camilo Bernal CLA 2012-06-28 16:33:30 EDT
Created attachment 218056 [details]
Updated patch to reflect current changes on master.
Comment 13 Camilo Bernal CLA 2013-05-07 15:55:32 EDT
Patch submitted on gerrit using Perf's built-in comparison support: https://git.eclipse.org/r/#/c/11996/

Currently on hold until M7.
Comment 14 Camilo Bernal CLA 2013-05-27 14:15:50 EDT
The perf comparison feature has been commit on master in commit 100e4be5e9762493f06a975ba807187131557d72.