Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 371128 - Easy path for plugin installation from GitHub
Summary: Easy path for plugin installation from GitHub
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.4   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 0.4 RC1   Edit
Assignee: Mark Macdonald CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-09 14:48 EST by Mark Macdonald CLA
Modified: 2012-02-13 14:09 EST (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Macdonald CLA 2012-02-09 14:48:13 EST
It should be really easy to install a 3rd-party plugin from the plugin list on GitHub [1], or an "Orion marketplace", or some other source of plugin URLs.

This has two parts:

1. On the Orion side, generate a link to the plugin list in some prominent spot. The link should include an 'orion' parameter giving the URL of your Orion server.

2. On the GitHub side, check for the 'orion' parameter in the URL and generate an "Install into Orion" link that installs the plugin onto your Orion server.

This would let you find and install a plugin with about 3 clicks and no copying of URLs.

[1] http://mamacdon.github.com/
Comment 1 Ken Walker CLA 2012-02-09 14:54:56 EST
Either this depends on Bug 370588 or is a duplicate?
Comment 2 Mark Macdonald CLA 2012-02-09 15:05:57 EST

*** This bug has been marked as a duplicate of bug 370588 ***
Comment 3 Mark Macdonald CLA 2012-02-10 16:30:18 EST
(In reply to comment #2)
> 
> *** This bug has been marked as a duplicate of bug 370588 ***

On second thought, this should be a dependency not a dupe.
Comment 4 Mark Macdonald CLA 2012-02-10 16:30:39 EST
.
Comment 5 Mark Macdonald CLA 2012-02-10 19:29:46 EST
Added a "Get Plugins" link to the nav toolbar:
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=d50aff439c48b640b2bfa7de4c99fb2a7e4fe53b

The Github side:
https://github.com/mamacdon/mamacdon.github.com/commit/f18cee8b8090f8daec65647dc6120043b234d7cc

I've included a version number to scope down the list of available plugins you can install. Reload your plugins (or wait an hour), try it out, and let me know what you think.
Comment 6 Susan McCourt CLA 2012-02-11 22:06:54 EST
(In reply to comment #5)
> I've included a version number to scope down the list of available plugins you
> can install. Reload your plugins (or wait an hour), try it out, and let me know
> what you think.

I think this workflow is perhaps the coolest thing I've seen that shows off how exposing the right bits of functionality can construct a pretty seamless workflow.  I could imagine all kinds of "catalog providers" wanting to do this.

If we wanted to pretend you never left Orion, we could even style that page more like Orion, but I don't think we are pretending, so I'm not suggesting we do that.  But I think some users will never realize they were on Mark's github site.

Way cool!
I opened bug 371318 for a scroll bar glitch that I found on Chrome (didn't try elsewhere)
Comment 7 Mark Macdonald CLA 2012-02-12 15:04:20 EST
(In reply to comment #6)
> (In reply to comment #5)
> > I've included a version number to scope down the list of available plugins you
> > can install. Reload your plugins (or wait an hour), try it out, and let me know
> > what you think.
> 
> I think this workflow is perhaps the coolest thing I've seen that shows off how
> exposing the right bits of functionality can construct a pretty seamless
> workflow.  I could imagine all kinds of "catalog providers" wanting to do this.

In this example the catalog provider is coupled to the command's URL binding: ie. the GitHub page knows that "#plugins?installPlugin=" + pluginURL is the magic string to install a plugin on the Settings page.

I'm sure we could abstract this step into a passing a URI template, so the provider wouldn't be coupled to any particular URL structure... It would just look at the params and decide how to supply them.
Comment 8 John Arthorne CLA 2012-02-13 12:59:08 EST
Yep this is really cool stuff. Ken and I were trying it out this morning and it worked smoothly. We were wondering if the top toolbar was the right place for the "Get Plugins" link.  Another option would be a hyperlink somewhere at the top of the Plugins tab of the Settings page. Susan any thoughts on that?
Comment 9 Susan McCourt CLA 2012-02-13 14:09:24 EST
(In reply to comment #8)
> Yep this is really cool stuff. Ken and I were trying it out this morning and it
> worked smoothly. We were wondering if the top toolbar was the right place for
> the "Get Plugins" link.  Another option would be a hyperlink somewhere at the
> top of the Plugins tab of the Settings page. Susan any thoughts on that?

I actually told Mark to put it there.  From http://wiki.eclipse.org/Orion/Page_Layout#Defining_Page_Elements

>Discovery links appear prominently/consistently on the page to teach you what >can you do. These links may even link to other sites. They are the least related >to the task at hand, but you should know about them.

Our general approach is top down.  Up top is more "global" and as you go down the links become more specific.

If this ends up surprising people, we can revisit, but it was definitely intentional.