Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 371121 - Should command icon tooltips show the command name?
Summary: Should command icon tooltips show the command name?
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.4   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.4 RC3   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-09 13:45 EST by Mark Macdonald CLA
Modified: 2012-02-21 22:29 EST (History)
4 users (show)

See Also:
ken_walker: review+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Macdonald CLA 2012-02-09 13:45:35 EST
Here's something I found weird about the new visual styling as shown on the git-repository page. Most commands are now icons with no label, and it's not always clear what the command name is. Sometimes the tooltip tells you, other times it doesn't.

For example, the 'checkout' command's tooltip:
> Make the branch or corresponding local branch active. If the remote 
> tracking branch does not have a corresponding local branch, the local 
> branch will be created first.

This never actually mentions the word 'checkout' anywhere, although that's what this action is called in Git land.

The cherry-pick command has a similar problem, although maybe its icon is self-explanatory (it kind of looks like oranges to me though).
Comment 1 Susan McCourt CLA 2012-02-10 09:48:14 EST
I thought I had a bug open on this, but I might just be remembering a discussion I had with Szymon.  Some time ago, we used the command name as the tooltip in the icon case for this very reason.  Szymon proposed an expanding tooltip for icons, where you hover and get the name, and if you linger longer you get the full tooltip.  I can't find anywhere we captured that idea.

In the meantime we were trying to use the command name as the first word of the tooltip for the reason you describe.  We need another pass on this.  I'll keep this bug open for RC2, and also made a note in bug 369867, because we also need to make a pass on command names, shorten them up, etc.

I know a lot of effort has been put into the git tooltips so I will be careful, but I agree completely that the git word in general needs to be prominent, if not the first word, in the tooltip.
Comment 2 Susan McCourt CLA 2012-02-21 22:05:19 EST
fix in remote branch
 origin/bug371121

commit SHA is
 6b85675578bb13014672823c83a301265c49a9a9

I did a very minimal pass:
- All "checkout" commands start with "checkout"
- Git status "reset" starts with "reset"
- changed "Go to eclipse.org" to "Show in eclipse.org"  This issue was discussed in bug 369867 but I'm deferring that one.

Ken, okay to fix?
Comment 3 Ken Walker CLA 2012-02-21 22:19:54 EST
As a Project Lead I +1 this change.

These are all text only, no code changes.
Comment 4 Susan McCourt CLA 2012-02-21 22:29:09 EST
pushed fix, ken said okay to skip review since changes are text only.