Description Dani Megert 2012-02-09 07:46:03 EST

I20120208-0800.

One can't see if a combo has focus among other widgets. Works fine if e.g. a button has the focus. This is a major usability problem.

Test Case:

1. paste the snippet [1]
2. run it
   ==> you can clearly see the focus - it's on the button
3. change the snippet to set the focus on the combo
4. run it
   ==> no clue which widget has the focus

EXPECTED: either we also see a bluish indicator like for the button or we at least show the focus ring.

Also, if I click on the widgets with the mouse, I can see the focus for the button but not the combo.

And yes, I know that this is the standard Windows 7 behavior. But similar to bug 342282 we need to override it if it's not working well.


[1]
import org.eclipse.swt.SWT;
import org.eclipse.swt.layout.RowLayout;
import org.eclipse.swt.widgets.Button;
import org.eclipse.swt.widgets.Combo;
import org.eclipse.swt.widgets.Display;
import org.eclipse.swt.widgets.Event;
import org.eclipse.swt.widgets.Label;
import org.eclipse.swt.widgets.Listener;
import org.eclipse.swt.widgets.Shell;

public class Snippet {


    public static void main(final String[] args) {
        final Display display = new Display();

        Shell shell = new Shell(display);
        shell.setLayout(new RowLayout());

        Label label = new Label(shell, SWT.SINGLE);
        label.setText("text:");
        final Combo combo = new Combo(shell, SWT.DROP_DOWN | SWT.READ_ONLY);
        combo.setItems(new String[] {"hello", "hi"});
        combo.select(0);
        Button button = new Button(shell, SWT.PUSH);
        button.setText("button");

        display.addFilter(SWT.KeyDown, new Listener() {
            public void handleEvent(Event event) {
                if (event.keyCode == SWT.F1) {
                    combo.redraw();
                    System.out.println("redrawing");
                }
            }
        });
        shell.setSize(200, 200);
        shell.open();
		button.setFocus();
//		combo.setFocus();
        while (!shell.isDisposed()) {
            if (!display.readAndDispatch())
                display.sleep();
        }

        display.dispose();
    }
}