Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 371065 - e4.ui.tests failures in I20120208-2200
Summary: e4.ui.tests failures in I20120208-2200
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Remy Suen CLA
QA Contact:
URL: http://download.eclipse.org/eclipse/d...
Whiteboard:
Keywords:
Depends on:
Blocks: 320478
  Show dependency tree
 
Reported: 2012-02-09 07:22 EST by Paul Webster CLA
Modified: 2012-02-14 10:46 EST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2012-02-09 07:22:05 EST 
There are 2 errors, 6 failures, but they all seem to be related to toolbar not having its widget created.

junit.framework.AssertionFailedError: null
at org.eclipse.e4.ui.tests.workbench.PartRenderingEngineTests.testBug334580_01(PartRenderingEngineTests.java:2273)
at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:416)
at org.eclipse.test.EclipseTestRunner.run(EclipseTestRunner.java:249)
at org.eclipse.test.CoreTestApplication.runTests(CoreTestApplication.java:36)
at org.eclipse.test.CoreTestApplication.run(CoreTestApplication.java:32)
at org.eclipse.equinox.internal.app.EclipseAppContainer.callMethodWithException(EclipseAppContainer.java:587)
at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:198)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:352)
at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:624)
at org.eclipse.equinox.launcher.Main.basicRun(Main.java:579)
at org.eclipse.equinox.launcher.Main.run(Main.java:1433)
at org.eclipse.equinox.launcher.Main.main(Main.java:1409)
at org.eclipse.core.launcher.Main.main(Main.java:34)
Comment 2 Dean Roberts CLA 2012-02-14 10:33:13 EST 
This patch breaks much of the CustomizePerspectiveDialog functionality added by Bug 320478.

For instance, with this particular fix in none of the Java Navigation toolbar items can be turned off.

Are we sure the failing tests are correct?  Should the "missing" tool bar items really be there or was this test modified to work around the bug that tool items could not be hidden?
Comment 3 Remy Suen CLA 2012-02-14 10:40:21 EST 
(In reply to comment #2)
> This patch breaks much of the CustomizePerspectiveDialog functionality added by
> Bug 320478.

The fix is completely wrong, my mistake.

> Are we sure the failing tests are correct?

The tests failed to run to completion because the rendering engine died from an NPE. The tests had nothing to do with whether individual items should be visible or not, so they are valid tests.