Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 370923 - Precedence in the class BPELwriter
Summary: Precedence in the class BPELwriter
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: BPEL (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-08 04:23 EST by neto CLA
Modified: 2022-10-03 11:11 EDT (History)
1 user (show)

See Also:


Attachments
The New BPELWriter with the change (79.86 KB, application/octet-stream)
2012-02-08 04:23 EST, neto CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description neto CLA 2012-02-08 04:23:32 EST
Created attachment 210713 [details]
The New BPELWriter with the change

My suggestion is to evaluate if an activity is an ExtensionActivity at the begin (instead of testing it at the end). Thus, when the BPELWriter find a extension activity that extends an BPEL activity, it call the serializer of the extension (that can reuse the serializer of the BPEL extended activity). For instance, in my tool I created a new class that extends from Scope and ExtensionActivity. However, without this change when the BPEL Designer is reading the process, it consider my extended activity as a normal Pick (ignoring my extension).

Well, maybe the text is a bit confusing, but it is just a small suggestion to improve the extensibility of the tool. The stretch of the code that could be changed is in the following.

public Element activity2XML(Activity activity) {

   Element activityElement = null;

   if (activity instanceof ExtensionActivity)
        activityElement = extensionActivity2XML((ExtensionActivity) activity);
    else if (activity instanceof Empty)
        activityElement = empty2XML((Empty) activity);
...

}
Comment 1 Robert Brodt CLA 2012-02-09 12:16:29 EST
Sorry it took so long - was having network problems here ;)
Please close this BZ when you've verified it.