370915 – [Pattern Post Processor] Pattern output nodes should follow the visitor "pattern"

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 370915 - [Pattern Post Processor] Pattern output nodes should follow the visitor "pattern"

Summary: [Pattern Post Processor] Pattern output nodes should follow the visitor "patt...

Status:	CLOSED FIXED

Alias:	None

Product:	EMF.EGF
Classification:	Modeling
Component:	Core (show other bugs)
Version:	unspecified
Hardware:	All All

Importance:	P3 enhancement (vote)
Target Milestone:	---
Assignee:	Thomas Guiu
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2012-02-08 03:45 EST by Matthieu Helleboid
Modified:	2012-05-28 10:42 EDT (History)
CC List:	1 user (show)

See Also:

Attachments
implementation (1.32 KB, patch) 2012-02-08 06:15 EST, Matthieu Helleboid	no flags	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Matthieu Helleboid

2012-02-08 03:45:38 EST

Build Identifier: 

A pattern output processor allows to access a tree of node. It would be helpful that this tree implements the visitor design pattern to ease iteration on the subnodes. For example, an accept(...) method on org.eclipse.egf.model.pattern.Node would do it.

Reproducible: Always

Comment 1 Matthieu Helleboid

2012-02-08 03:56:00 EST

It would also be helpful to have an DefaultPatternOutputProcessor class which implements PatternOutputProcessor and does nothing to avoid the need to implements all methods of PatternOutputProcessor

Comment 2 Benoit Langlois

2012-02-08 04:10:30 EST

Hi,

Agree with the two points. Matthieu, I think that you can split this bug into two bugs for each request.

Benoît

Comment 3 Matthieu Helleboid

2012-02-08 04:21:58 EST

Hi Benoit, 

you're right, and it came to mind as soon as I hitted the submit button :-)
done : https://bugs.eclipse.org/bugs/show_bug.cgi?id=370920

Thx

Comment 4 Matthieu Helleboid

2012-02-08 06:15:25 EST

Created attachment 210720 [details]
implementation

Comment 5 Thomas Guiu

2012-02-09 04:21:02 EST

The visitor class has been added.

Comment 6 Benoit Langlois

2012-05-28 10:42:37 EDT

OK