Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 370896 - OpenResourceDialog should disambiguate results using friendly project names
Summary: OpenResourceDialog should disambiguate results using friendly project names
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.4   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 0.4 RC1   Edit
Assignee: libing wang CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-07 17:27 EST by Mark Macdonald CLA
Modified: 2012-02-09 11:48 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Macdonald CLA 2012-02-07 17:27:48 EST
I20120206-2230 on orion.eclipse.org

1. Go to Navigator
2. Press 't' to show OpenResourceDialog
3. Search for 'index.html'
4. I get hits for index.html's from several projects. The dialog shows the full path of each result to disambiguate them (good). But the paths are shown using internal project names ("/file/Aa", "/file/bc", etc) not user-friendly names.

I quickly looked at the search result data returned by the server and it does seem to include a field ('Path') that gives the user-friendly project name. The dialog seems to be relying on the 'Location' instead. Is this intentional?
Comment 1 John Arthorne CLA 2012-02-08 07:36:07 EST
I don't think it's intentional.
Comment 2 libing wang CLA 2012-02-08 08:55:00 EST
Some thing similar in global search:
The "path" is returned by server as well. It is the full file name rather than  parent folder name. Although not ideal but we can think about trimming the last segment off so that we can get the readable folder name. I am not trimming that in global search because I have to ask file meta data anyway.
Once we decide to trim that I can do the same thing in the global search. This will at least visually speed up the page loading, where asking meta data will happen completely silent.
Comment 3 libing wang CLA 2012-02-09 09:49:40 EST
I'll look at it and make a helper in searchUtil for both resource dialog and global search.
Comment 4 libing wang CLA 2012-02-09 11:39:10 EST
fixed with http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=da4529909f0b7399a72875f4938e9ee2aa3efc61.

But if you have two identical favorites names, you can not expect the "path" part to be readable because a favorite can be any URL.
Comment 5 libing wang CLA 2012-02-09 11:45:35 EST
Bug 371106 opened for global search to use the same helper.
Comment 6 Ken Walker CLA 2012-02-09 11:48:02 EST
just tried this, looks much better