Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 370881 - Add JUnit to test target runtime filter rule
Summary: Add JUnit to test target runtime filter rule
Status: RESOLVED FIXED
Alias: None
Product: WTP Common Tools
Classification: WebTools
Component: wst.validation (show other bugs)
Version: 3.0.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3.2   Edit
Assignee: Rosendo Martinez CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard: PMC_Approved
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-07 15:19 EST by Rosendo Martinez CLA
Modified: 2012-02-22 13:17 EST (History)
4 users (show)

See Also:
rosendo: pmc_approved? (david_williams)
raghunathan.srinivasan: pmc_approved+
rosendo: pmc_approved? (naci.dai)
rosendo: pmc_approved? (deboer)
rosendo: pmc_approved? (neil.hauge)
kaloyan: pmc_approved+
rosendo: pmc_approved? (cbridgha)
ccc: review+

Attachments
3_3_maintenance junit code (5.52 KB, patch)
2012-02-08 12:33 EST, Rosendo Martinez CLA 		no flags Details | Diff
3_3_maintenance junit code. Header was added to the new source file (6.06 KB, patch)
2012-02-08 16:40 EST, Rosendo Martinez CLA 		ccc: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rosendo Martinez CLA 2012-02-07 15:19:15 EST 
Build Identifier: 

Need to create junit to test the new target runtime filer rule support in validation framework.

See https://bugs.eclipse.org/bugs/show_bug.cgi?id=366065 for more details.

Reproducible: Always
Comment 1 Rosendo Martinez CLA 2012-02-08 12:33:16 EST 
Created attachment 210746 [details]
3_3_maintenance junit code
Comment 2 Rosendo Martinez CLA 2012-02-08 16:40:51 EST 
Created attachment 210756 [details]
3_3_maintenance junit code. Header was added to the new source file
Comment 3 Carl Anderson CLA 2012-02-08 16:46:27 EST 
Please ensure that this JUnit runs properly before releasing.

Looks good- I approve.
Comment 4 Rosendo Martinez CLA 2012-02-08 17:33:13 EST 
PMC Review requested due to junit change

Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug"
(requested by an adopter) please document it as such.

This junit code is introduced to test new functionality in Validation Framework.

Is there a work-around? If so, why do you believe the work-around is
insufficient?

There is no workaround.


How has the fix been tested? Is there a test case attached to the bugzilla
record? Has a JUnit Test been added?

This has been tested by hand and by running all the Validation Framework junit test bucket.


Give a brief technical overview. Who has reviewed this fix?

Carl Anderson has reviewed this fix.

Target runtime filter rule support was added in Validation Framework.
This junit code will test this new functionality.


What is the risk associated with this fix?

Low - This is only to test new functionality in Validation Framework.
Comment 5 Roberto Sanchez Herrera CLA 2012-02-09 09:47:33 EST 
Code committed to R3_3_maintenance and HEAD for WTP 3.3.2 and 3.4.