Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 370851 - compare could highlight changes within a line
Summary: compare could highlight changes within a line
Status: RESOLVED DUPLICATE of bug 373653
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.4   Edit
Hardware: PC Windows 7
: P3 enhancement (vote)
Target Milestone: 0.5   Edit
Assignee: libing wang CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-07 11:18 EST by Susan McCourt CLA
Modified: 2012-03-29 10:12 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2012-02-07 11:18:12 EST
I was noticing today that the github commit viewer is more helpful than ours for viewing diffs because they help to show what changed within a line.

For an example see:
https://github.com/max-li/orion.client/commit/37937d27dcab9963601cfdc05ac81794ff4b0e98
Comment 1 libing wang CLA 2012-02-07 11:41:04 EST
I was thinking about this when I started to use jsDiff. I noticed that they have char level diff. Did not have a chance to unit test it yet. But the worst case is that we write one by ourselves.

I think eventually we should have our compare widget to be able to show all the diff blocks + all the changes within each block.
From the navigation point of view, there should also be current diff + current change concept, just like Eclipse does.
Comment 2 libing wang CLA 2012-03-29 10:12:50 EDT
Two compare is basically working on the char/word level diff. Inline compare will use the same navigation model.

*** This bug has been marked as a duplicate of bug 373653 ***