Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 370837 - Generated content assist parser has warnings: discouraged access to IPartialContentAssistParser
Summary: Generated content assist parser has warnings: discouraged access to IPartialC...
Status: CLOSED FIXED
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 minor (vote)
Target Milestone: RC3   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-07 10:13 EST by Matthieu Wipliez CLA
Modified: 2017-10-31 11:18 EDT (History)
6 users (show)

See Also:
sven.efftinge: kepler+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matthieu Wipliez CLA 2012-02-07 10:13:49 EST
Build Identifier: 20120202-1513

Hi,

when I re-run my .mwe2 with Xtext 2.3.0, I now see two warnings per content assist parser generated related to Discouraged access to IPartialContentAssistParser. The warnings also show in the default Xtext project. However, content assist seems to work fine, so I'm reporting this as a minor bug.

Cheers
Matthieu

Reproducible: Always

Steps to Reproduce:
1. create a new Xtext project
2. run the .mwe2 workflow
3. wait until workspace is built
4. observe the two warnings
Comment 1 Andrew Clark CLA 2012-06-29 07:10:39 EDT
Is there any progress on this problem? Or a workaround

We have a 'zero warning' policy on our projects, and after upgrading to 2.3 we have this warning in all our UI projects.

Currently I am creating a new access rule to set 

org/eclipse/xtext/ui/codetemplates/ui/partialEditing/IPartialContentAssistParser

accessible for each UI project.

I am not sure if this is a good solution :-( 

Could not the generated code contain a suppress warnings annotation for these cases?
Comment 2 Matthieu Wipliez CLA 2013-05-31 10:32:55 EDT
Hello,

what is the status of this bug?
All is needed is to remove ';x-internal:=true' after org.eclipse.xtext.ui.codetemplates.ui.partialEditing in the MANIFEST.MF file of org.eclipse.xtext.ui.codetemplates.ui plug-in.

Or as mentioned by Andrew, having a SuppressWarnings annotation.

Is there a technical reason for not doing either one of these changes?

Thank you,
Matthieu
Comment 3 Sven Efftinge CLA 2013-05-31 14:09:39 EDT
We should at least add @SuppressWarnings for 2.4.2
Comment 4 Sven Efftinge CLA 2013-06-05 05:15:36 EDT
an @SuppressWarnings annotation is now generated.
Comment 5 Matthieu Wipliez CLA 2013-06-05 05:16:36 EDT
Thank you Sven!
Comment 6 Eclipse Webmaster CLA 2017-10-31 11:07:20 EDT
Requested via bug 522520.

-M.
Comment 7 Eclipse Webmaster CLA 2017-10-31 11:18:47 EDT
Requested via bug 522520.

-M.