Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 370832 - Auto publish will not triggered for structure changes
Summary: Auto publish will not triggered for structure changes
Status: RESOLVED FIXED
Alias: None
Product: WTP ServerTools
Classification: WebTools
Component: wst.server (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.5 P   Edit
Assignee: Elson Yuen CLA
QA Contact: Elson Yuen CLA
URL:
Whiteboard:
Keywords:
Depends on: 370766
Blocks:
  Show dependency tree
 
Reported: 2012-02-07 09:58 EST by Elson Yuen CLA
Modified: 2017-10-11 16:37 EDT (History)
2 users (show)

See Also:


Attachments
v1.0 (939 bytes, patch)
2012-02-07 10:09 EST, Elson Yuen CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Elson Yuen CLA 2012-02-07 09:58:01 EST
+++ This bug was initially created as a clone of Bug #370766 +++

Build Identifier: 3.2.maintance

I am looking at the code below in the Server.ResouceChangeJob#run().  It appears to me that a publish will not happen after the structure change if there is no module file changed.  A structure change can be recorded in a .XXX file in the project but it doesn't need to be a part of the module.  I think it should be published.


			// run the visitor
			visit(visitor, null);
			
			if (getServerPublishInfo().hasStructureChanged(modules2)) {
				int newState = getServerPublishState() == IServer.PUBLISH_STATE_FULL ? IServer.PUBLISH_STATE_FULL : IServer.PUBLISH_STATE_INCREMENTAL;
				setServerPublishState(newState);
			}
			
			if (!changed[0])
				return Status.OK_STATUS;
			
			if (getServerState() != IServer.STATE_STOPPED && behaviourDelegate != null)
				behaviourDelegate.handleResourceChange();
			
			if (getServerState() == IServer.STATE_STARTED)
				autoPublish(event);
			
			return Status.OK_STATUS;


Reproducible: Always
Comment 1 Elson Yuen CLA 2012-02-07 09:59:23 EST
This defect is to check in changes on bug 370766 to 325P code stream.
Comment 2 Elson Yuen CLA 2012-02-07 10:09:44 EST
Created attachment 210649 [details]
v1.0
Comment 3 Elson Yuen CLA 2012-02-07 10:31:56 EST
Changes released to HEAD
Comment 4 Elson Yuen CLA 2012-02-09 18:20:50 EST
Code released to 325P
Comment 5 Eclipse Genie CLA 2017-10-11 16:37:50 EDT
New Gerrit change created: https://git.eclipse.org/r/109093