Community
Participate
Working Groups
On git-repository and other pages we use prompts to confirm some actions. For instance when one wants to delete a remote he is prompted to confirm. I wanted to replace prompts with popups and ParametersDescription for commands. I couldn't do it. If I use an empty array of command params, I indeed get "V/X" dialog but there is an error in the console and no label. Could we add it for .4?
I can't promise but I will look at the impact in RC2 (simply swamped for RC1 to take on any new features, even if they are small.)
Actually I want to move this to 0.5, it's really stretching this beyond the original intention and trying to hack it in usually introduces bugs. I think we will live with browser prompt dialogs. - no way we'd get this consistent during RC2 for all prompting commands (we aren't even consistent in using the slideout yet) - we'd have to introduce a new meaning to "parameter" if we wanted label and no text field. This should really be special API. - we have confirm dialogs when commands aren't used anyway - the visuals are still changing to get rid of OK and more buttons and use text. The text will be "Submit" and that would be kind of weird rather than "yes" For 0.5 I'm hoping that commands can specify the "action text" for OK so we could have verb buttons like "Create" or "Move" instead of just generic "Submit." When we add that API we could have a "Confirm" case. I suspect for the confirm case we would want visuals that look different than the gray color of parameter collecting, or at least I'd want to talk to Linda about it.
Yep I think we need to close down on feature work for 0.4.. not enough time to test/stabilize.
a slideout prompter would probably live in the dialog service? see bug 371157
After thinking about this a bit, I want to make this a duplicate of bug 371157, which is a bit more generic. We should definitely have a service that can be called to get a yes/no answer from the user, and there is definitely some synergy with parameter collectors and parameter descriptions. But I think the code belongs in what used to be called "dialog service." See the other bug for more discussion. *** This bug has been marked as a duplicate of bug 371157 ***
I'm reopening this bug so that this feature can be developed independently of fleshing out the user dialog service.
Fixed in http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=a80d7120d60b72adc51d890de3b1516403a50bed There is example usage in the example page examplePages/leftrightpanes.js If you want modal behavior, it reverts back to window.confirm, but otherwise you can get a slideout with yes/no buttons.
Created attachment 228289 [details] screenshot of single line and multi line slideout prompts
