Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 370748 - [Compatibility] With CDT, instruction stepping mode does not work
Summary: [Compatibility] With CDT, instruction stepping mode does not work
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.2   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 4.2 M6   Edit
Assignee: Remy Suen CLA
QA Contact: Remy Suen CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 331444
  Show dependency tree
 
Reported: 2012-02-06 12:50 EST by Marc-André Laperle CLA
Modified: 2012-03-13 08:44 EDT (History)
1 user (show)

See Also:

Attachments
Instruction stepping mode button (14.76 KB, image/png)
2012-02-06 13:50 EST, Marc-André Laperle CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marc-André Laperle CLA 2012-02-06 12:50:59 EST 
Using eclipse-cpp-juno-M5-win32-x86_64

1. Create a hello world project
2. Build the project
3. Debug the project, it should stop at main
4. In the Debug view, in the tree, click on the thread or process, then on the Step Instruction button. Nothing happens.

With 3.8M5, when the button is pressed, the button becomes enabled, the disassembly view opens and step over steps through instructions in Disassembly view.
Comment 1 Marc-André Laperle CLA 2012-02-06 13:50:01 EST 
Created attachment 210608 [details]
Instruction stepping mode button
Comment 2 Remy Suen CLA 2012-02-06 14:30:24 EST 
The action doesn't seem to be checked so the code doesn't even up showing the view.
Comment 3 Remy Suen CLA 2012-02-07 08:40:54 EST 
In 3.x we don't go through the ActionDelegateHandlerProxy so we don't get another call to selectionChanged(*) which prevents the action from thinking it is unchecked.

ToggleInstructionStepModeActionDelegate.run(IAction) line: 97	
ToggleInstructionStepModeActionDelegate.runWithEvent(IAction, Event) line: 117	
ViewPluginAction(PluginAction).runWithEvent(Event) line: 241	
PluginActionContributionItem(ActionContributionItem).handleWidgetSelection(Event, boolean) line: 584	
ActionContributionItem.access$2(ActionContributionItem, Event, boolean) line: 501	
ActionContributionItem$6.handleEvent(Event) line: 452	
EventTable.sendEvent(Event) line: 84	
ToolItem(Widget).sendEvent(Event) line: 1053
Comment 5 Remy Suen CLA 2012-03-13 08:44:33 EDT 
Verified with I20120312-1730 on Windows 7. Thank you for the bug report!