Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 370746 - Add support for application-based JNDI authentication
Summary: Add support for application-based JNDI authentication
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Justin Spadea CLA
QA Contact:
URL:
Whiteboard: jndi
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-06 12:24 EST by Justin Spadea CLA
Modified: 2017-02-23 14:07 EST (History)
0 users

See Also:


Attachments
Patch containing the changes (20.42 KB, patch)
2012-02-06 12:37 EST, Justin Spadea CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Spadea CLA 2012-02-06 12:24:56 EST
This was supported until we simplified the editor to remove the "Use an existing JNDI data source" option. We do need to support this though, so we should add a checkbox to the "Deploy as JNDI" section.

New parameter: jndiApplicationAuth

When true, deployment will define the resource-refs and data sources as auth="Application", otherwise it will continue to use auth="Container". Not all data sources support this, so it is up to the user to only check the box when their data source won't throw an error. For example, Tomcat's default data source "BasicDataSource" throws an error when trying to specify credentials from the application - you must only use container-based auth with that class.

I'm going to remove the jndiuser and jndiPassword parameters from the binding, we'll just reuse sqlID and sqlPassword. Deployment will fill these in automatically when jndiApplicationAuth is set true.
Comment 1 Justin Spadea CLA 2012-02-06 12:37:11 EST
Implemented as described. Will attach a patch with the changes.
Comment 2 Justin Spadea CLA 2012-02-06 12:37:38 EST
Created attachment 210605 [details]
Patch containing the changes
Comment 3 Justin Spadea CLA 2012-02-22 08:52:53 EST
Closing