Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 370736 - "Unexpected error: Invalid xsrfKey in request" when working with Gerrit
Summary: "Unexpected error: Invalid xsrfKey in request" when working with Gerrit
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 0.9   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-06 10:39 EST by Tomasz Zarna CLA
Modified: 2012-04-28 03:17 EDT (History)
3 users (show)

See Also:


Attachments
mylyn/context/zip (55.42 KB, application/octet-stream)
2012-02-09 22:38 EST, Steffen Pingel CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2012-02-06 10:39:46 EST
Sorry, don't remember the steps.

Mylyn Reviews Connector: Gerrit (Incubation)	0.9.0.I20120204-0747	org.eclipse.mylyn.gerrit.feature.feature.group	Eclipse Mylyn

-- Error Details --
Date: Mon Feb 06 16:35:31 CET 2012
Message: Unexpected error: Invalid xsrfKey in request
Severity: Error
Product: Eclipse SDK 3.8.0.v201201310910 (org.eclipse.sdk.ide)
Plugin: org.eclipse.mylyn.gerrit.core
Session Data:
eclipse.buildId=I20120131-0910
java.fullversion=JRE 1.6.0 IBM J9 2.4 Windows XP x86-32 jvmwi3260sr7-20091214_49398 (JIT enabled, AOT enabled)
J9VM - 20091214_049398
JIT  - r9_20091123_13891
GC   - 20091111_AA
BootLoader constants: OS=win32, ARCH=x86, WS=win32, NL=pl_PL
Command-line arguments:  -os win32 -ws win32 -arch x86

Exception Stack Trace:
org.eclipse.mylyn.internal.gerrit.core.client.GerritException: Invalid xsrfKey in request
	at org.eclipse.mylyn.internal.gerrit.core.client.JSonSupport.parseResponse(JSonSupport.java:203)
	at org.eclipse.mylyn.internal.gerrit.core.client.GerritService.invoke(GerritService.java:106)
	at $Proxy5.changeDetailX(Unknown Source)
	at org.eclipse.mylyn.internal.gerrit.core.client.GerritClient$4.execute(GerritClient.java:291)
	at org.eclipse.mylyn.internal.gerrit.core.client.GerritClient.execute(GerritClient.java:822)
	at org.eclipse.mylyn.internal.gerrit.core.client.GerritClient.getChangeDetail(GerritClient.java:288)
	at org.eclipse.mylyn.internal.gerrit.core.client.GerritClient.getChange(GerritClient.java:456)
	at org.eclipse.mylyn.internal.gerrit.core.GerritTaskDataHandler.getTaskData(GerritTaskDataHandler.java:90)
	at org.eclipse.mylyn.internal.gerrit.core.GerritConnector.getTaskData(GerritConnector.java:135)
	at org.eclipse.mylyn.internal.tasks.core.sync.SynchronizeTasksJob.synchronizeTask(SynchronizeTasksJob.java:245)
	at org.eclipse.mylyn.internal.tasks.core.sync.SynchronizeTasksJob.runInternal(SynchronizeTasksJob.java:218)
	at org.eclipse.mylyn.internal.tasks.core.sync.SynchronizeTasksJob.run(SynchronizeTasksJob.java:153)
	at org.eclipse.mylyn.internal.tasks.core.sync.SynchronizeTasksJob.run(SynchronizeTasksJob.java:129)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
Comment 1 Steffen Pingel CLA 2012-02-06 12:52:21 EST
Thanks for the report. This can happen when the cookie used for authentication expires. I believe we are missing some handling code to re-login and retry the request in this case. Is it correct to assume that you saw this error with git.eclipse.org?
Comment 2 Tomasz Zarna CLA 2012-02-07 04:39:41 EST
(In reply to comment #1)
> Is it correct to assume that you saw this error with git.eclipse.org?

That is correct.
Comment 3 Steffen Pingel CLA 2012-02-09 22:00:06 EST
Stack trace from http://www.eclipse.org/forums/index.php/m/795004/:

org.eclipse.mylyn.internal.gerrit.core.client.GerritException: Invalid xsrfKey in request
        at org.eclipse.mylyn.internal.gerrit.core.client.JSonSupport.parseResponse(JSonSupport.java:205)
        at org.eclipse.mylyn.internal.gerrit.core.client.GerritService.invoke(GerritService.java:106)
        at $Proxy16.myAccount(Unknown Source)
        at org.eclipse.mylyn.internal.gerrit.core.client.GerritClient$19.execute(GerritClient.java:707)
        at org.eclipse.mylyn.internal.gerrit.core.client.GerritClient.execute(GerritClient.java:823)
        at org.eclipse.mylyn.internal.gerrit.core.client.GerritClient.getAccount(GerritClient.java:704)
        at org.eclipse.mylyn.internal.gerrit.core.client.GerritClient.queryMyReviews(GerritClient.java:526)
        at org.eclipse.mylyn.internal.gerrit.core.GerritConnector.performQuery(GerritConnector.java:213)
        at org.eclipse.mylyn.internal.tasks.core.sync.SynchronizeQueriesJob.synchronizeQuery(SynchronizeQueriesJob.java:311)
        at org.eclipse.mylyn.internal.tasks.core.sync.SynchronizeQueriesJob.synchronizeQueries(SynchronizeQueriesJob.java:268)
        at org.eclipse.mylyn.internal.tasks.core.sync.SynchronizeQueriesJob.run(SynchronizeQueriesJob.java:201)
        at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
Comment 4 Steffen Pingel CLA 2012-02-09 22:38:44 EST
I have released a fix which will be available in the next weekly build: https://hudson.eclipse.org/hudson/job/mylyn-release/175 . Please reopen this bug in case you see this error again after updating.
Comment 5 Steffen Pingel CLA 2012-02-09 22:38:48 EST
Created attachment 210833 [details]
mylyn/context/zip
Comment 6 Ron K CLA 2012-02-10 08:12:53 EST
Hi, the problem affected me too.  After upgrading to the latest weekly,
I managed to authenticate and login correctly as before.   This provides some evidence that the issue is indeed resolved.

Thanks,

--Ron
Comment 7 Bryan Hunt CLA 2012-03-16 13:47:41 EDT
I've just run into this same problem with Gerrit 2.3-rc0 and I even tried updating to today's nightly build.  I'm Using Eclipse 4.2 M5 on OS X.  Here's the stack I get in the error log:


eclipse.buildId=I20120127-1145
java.version=1.6.0_29
java.vendor=Apple Inc.
BootLoader constants: OS=macosx, ARCH=x86_64, WS=cocoa, NL=en_US
Framework arguments:  -keyring /Users/bhunt/.eclipse_keyring -showlocation
Command-line arguments:  -os macosx -ws cocoa -arch x86_64 -keyring /Users/bhunt/.eclipse_keyring -showlocation

Error
Fri Mar 16 12:42:35 CDT 2012
Unexpected error: Invalid xsrfKey in request

org.eclipse.mylyn.internal.gerrit.core.client.GerritException: Invalid xsrfKey in request
	at org.eclipse.mylyn.internal.gerrit.core.client.JSonSupport.parseResponse(JSonSupport.java:205)
	at org.eclipse.mylyn.internal.gerrit.core.client.GerritService.invoke(GerritService.java:106)
	at $Proxy30.myAccount(Unknown Source)
	at org.eclipse.mylyn.internal.gerrit.core.client.GerritClient$20.execute(GerritClient.java:746)
	at org.eclipse.mylyn.internal.gerrit.core.client.GerritClient.executeOnce(GerritClient.java:877)
	at org.eclipse.mylyn.internal.gerrit.core.client.GerritClient.execute(GerritClient.java:867)
	at org.eclipse.mylyn.internal.gerrit.core.client.GerritClient.getAccount(GerritClient.java:743)
	at org.eclipse.mylyn.internal.gerrit.core.client.GerritClient.queryMyReviews(GerritClient.java:557)
	at org.eclipse.mylyn.internal.gerrit.core.GerritConnector.performQuery(GerritConnector.java:213)
	at org.eclipse.mylyn.internal.tasks.core.sync.SynchronizeQueriesJob.synchronizeQuery(SynchronizeQueriesJob.java:311)
	at org.eclipse.mylyn.internal.tasks.core.sync.SynchronizeQueriesJob.synchronizeQueries(SynchronizeQueriesJob.java:268)
	at org.eclipse.mylyn.internal.tasks.core.sync.SynchronizeQueriesJob.run(SynchronizeQueriesJob.java:201)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
Comment 8 Steffen Pingel CLA 2012-03-16 14:48:06 EDT
Sorry, Gerrit 2.3 is not yet supported. Please file a separate bug to request that and we can consider it as part of the next release cycle.
Comment 9 Steffen Pingel CLA 2012-03-29 17:46:29 EDT
I have opened bug 375672 to track support for Gerrit 2.3.