Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 370712 - [JUnit] Incorrect decorator in JUnit view's icon
Summary: [JUnit] Incorrect decorator in JUnit view's icon
Status: RESOLVED WONTFIX
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.8   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: JDT-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-06 07:58 EST by Deepak Azad CLA
Modified: 2012-02-13 13:07 EST (History)
2 users (show)

See Also:


Attachments
screenshot (25.04 KB, image/png)
2012-02-06 07:58 EST, Deepak Azad CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Deepak Azad CLA 2012-02-06 07:58:40 EST
Created attachment 210573 [details]
screenshot

In JUnit view's icon the decorator is either a 'green tick' or a 'red x', but never a 'blue x'.

If a Test suite has only 'failures' but no 'errors', the view's icon should use the 'blue x' as decorator, as the blue icon is used inside the view to indicate failures.

See attached screenshot.
Comment 1 Dani Megert CLA 2012-02-06 08:15:03 EST
We use "red" since day one and also the progress bar in the view is red and not blue. Also, the dark-blue decorator would not be as visible as the red one.
Comment 2 Deepak Azad CLA 2012-02-06 08:30:06 EST
sigh.. 

What if we use red icons for both error and failure?
Error   - a red '!' (same as the one we use for build path error)
Failure - a red x

Then maybe we can use the appropriate decorator in the view's icon. The progress bar can remain red for both error and failure.
Comment 3 Dani Megert CLA 2012-02-06 08:52:50 EST
Yes we "could" do that but then we'd also have to fix the icons in the view and the request a new toolbar icon from the designers for not much additional value.

In that sense also the "Show Failures Only" isn't 100% correct but it does its job.
Comment 4 Markus Keller CLA 2012-02-13 13:07:51 EST
Note that JUnit 4 dropped the distinction between error and failures (also failed assertions are errors now), so this change would be hard to justify now.