Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 370656 - [assist] remove signatures from method binding chokes on inline comment
Summary: [assist] remove signatures from method binding chokes on inline comment
Status: VERIFIED FIXED
Alias: None
Product: Objectteams
Classification: Tools
Component: OTDT (show other bugs)
Version: 2.1   Edit
Hardware: Other Linux
: P3 normal (vote)
Target Milestone: 2.1 M6   Edit
Assignee: Stephan Herrmann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-05 08:29 EST by Stephan Herrmann CLA
Modified: 2012-09-22 16:31 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Herrmann CLA 2012-02-05 08:29:06 EST 
Given this callin binding

	void checkAgainstInheritedMethods(MethodNode currentMethod,
			MethodNode[] methods /* remaining args are ignored*/)
	<- after
	void checkAgainstInheritedMethods(MethodBinding currentMethod,
			MethodBinding[] methods, int length,
			MethodBinding[] allInheritedMethods);

invoking the quick assist "Remove signatures..." creates bogus output:
	checkAgainstInheritedMethods/* remaining args are ignored */)
	<- after
	checkAgainstInheritedMethods;

Someone forgot to remove the closing ')' :)
Comment 1 Stephan Herrmann CLA 2012-02-05 13:15:18 EST 
AstRewriteAnalyzer needs to properly scan over comments and trailing ')' instead of just adding offset 1 after the last parameter.

Resolved for 2.1 M6 via commit 72d84d535b4ae88b8ed728eea05fd9c732187e01
Comment 2 Stephan Herrmann CLA 2012-09-22 16:31:02 EDT 
Verified using build 2.2.0.201209221349