Community
Participate
Working Groups
In bug 369892, new dependencies on orion modules were added to OpenResourceDialog.js. This worked correctly on a deployed self-hosting environment, but failed when run through our build. My only guess is that perhaps there is a path problem because this widget is in a different directory from other Orion scripts with module imports.
I have been debugging the built code, and I'm starting to think this is a require.js bug. 1) I put a breakpoint inside the module definition for "orion/globalCommands", which is referencing "orion/searchRenderer". 2) I put a breakpoint inside the definition of the "orion/searchRenderer" 1) is getting hit before 2). So, the code that requires the renderer gets executed before the search renderer module even gets defined. Of course the required module is passed in as null and the execution fails. We have fairly deeply nested modules here and I wonder if we are hitting: https://github.com/jrburke/requirejs/issues/173 This is supposedly fixed in Require.js version 1.0.5. I think to get us going again I'll have to inline the rendering code again, and revisit after we moved up to require.js 1.0.5.
Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see: https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html
