Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 370597 - Block commenting
Summary: Block commenting
Status: CLOSED FIXED
Alias: None
Product: LDT
Classification: Tools
Component: LuaDevelopmentTools (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal
Target Milestone: 0.8 M1   Edit
Assignee: Benjamin Cabé CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-03 14:21 EST by Marc Ewert CLA
Modified: 2012-02-27 06:25 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marc Ewert CLA 2012-02-03 14:21:38 EST
I'm using the key combination Strg-7 resp. Strg-Shift-/ for commenting and uncommenting blocks of code a lot in the Eclipse java editor. It would be great, if LDT also supports this command. LunarEclipse has this feature, but apparantly also a few more bugs. ;-)
Comment 1 Marc Ewert CLA 2012-02-03 14:37:44 EST
I've just found out, that it is bound to the key "Ctrl-Shift-C". Is there any chance to put it to the standard key "Ctrl-Shift-7"? I was not able to change it to this key combination, why ever.
Comment 2 Benjamin Cabé CLA 2012-02-03 14:51:17 EST
Hi Marc!

It sounds like a bug, since Ctrl+7 works well with other DLTK-based editor such as Ruby. I will investigate...

Thanks for the nice feedback, keep on providing it, we appreciate it very much :)
Comment 3 Marc Ewert CLA 2012-02-04 03:51:47 EST
Hi Benjamin,

thanks for your fast reply.  :-)

It's a very strange issue. When I bind the command to something different then Ctrl-Shift-C it's not functioning anymore. I've resetted my keymap to the default values, but it didn't help.

I just saw that there is also a default mapping "Ctrl-Shift-/" for "Add Comment Block" which is probably for your plugin (When: Editing in structured Text Editors). But it doesn't function. Even if I bind it to "Ctrl-u".

Commenting blocks of code in Java-Code is functioning with "Ctrl-Shift-/" in the same workspace.

Is it perhaps caused by the german keymap I'm using? Things like the "/" character are located at a different key on the german keymap.
Comment 4 Benjamin Cabé CLA 2012-02-04 13:22:38 EST
Hi Marc,
I just fixed it. If you update your LDT install, you should now be able to use either Ctrl+Shift+C, Ctrl+7, or  Ctrl+/ to trigger the "Toggle Comment" command.

Cheers
Benjamin –
Comment 5 Benjamin Cabé CLA 2012-02-04 13:23:17 EST
VERIFIED in 0.1.0.201202041759 on MacOSX 64
Comment 6 Marc Ewert CLA 2012-02-05 11:28:44 EST
Yes, i can also confirm on my german Windows7, thank you very much! :-)
Comment 7 Benjamin Cabé CLA 2012-02-09 08:44:21 EST
CLOSING as per latest Marc comment.