Community
Participate
Working Groups
I noticed that some of the code that was in setup.js got moved to a better place. But in the process some features got lost: apparently mTextStylerOptions is not being installed in the editor as consequence the editor preferences pages is not working also noticed that mTextStylerOptions was not removed from setup.js require list as it should have. other feature that was lost is folding (and while you are at, please make folding a preference ;-). Not saying that this code should go in highlight.js (as it was sort of hack in setup.js anyway) but this needs to be fixed. Thank you
(In reply to comment #0) > I noticed that some of the code that was in setup.js got moved to a better > place. > > > But in the process some features got lost: > apparently mTextStylerOptions is not being installed in the editor > as consequence the editor preferences pages is not working > also noticed that mTextStylerOptions was not removed from setup.js require list > as it should have. > other feature that was lost is folding Good catch, thanks! There was a bunch of styler-initialization code in setup that was a bit tangled, and I lost TextStylerOptions and folding while I was rearranging it. Fixed in http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=c5112a2bc6b45d70bf627c76b50ddfcdbf58d31a > (and while you are at, please make folding a preference ;-). Ok, I'll look at this in a follow-up commit. Maybe we should extract some common API from stylers so that something like TextStylerOptions can configure them all?
> Maybe we should extract some common API from stylers so that something like > TextStylerOptions can configure them all? I'm already added getClassNameForToken() to TextStyler because of TextStylerOptions. Lets talk Monday.
Opened bug 370965 for the folding pref. Closing this one, see commit comment 1.
