Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 370563 - [sites] toolbar commands don't work in site editor
Summary: [sites] toolbar commands don't work in site editor
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.4   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 major (vote)
Target Milestone: 0.4 RC1   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-03 10:35 EST by Mark Macdonald CLA
Modified: 2012-02-03 12:52 EST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Macdonald CLA 2012-02-03 10:35:25 EST
On localhost (running from HEAD, 20120203-1034)

1. Go to 'Sites' page
2. Create a new site configuration.
3. Click any of the 'Save'/'Start'/'Convert to Self-Hosting' buttons on the toolbar.
4. Nothing happens-- the commands do not run.

This doesn't happen on orion.eclipse.org (running I20120202-2230)
Comment 1 Susan McCourt CLA 2012-02-03 10:50:16 EST
fallout from bug 360986, I'll check.
I guess it wouldn't be an important change if I didn't break the sites page.
Sorry I'm so lazy about that one.  The "can't open individual sites page" has got me lazy exercising the list page.  I'll do better.
Comment 2 Mark Macdonald CLA 2012-02-03 11:20:04 EST
(In reply to comment #1)
> fallout from bug 360986, I'll check.
> I guess it wouldn't be an important change if I didn't break the sites page.
> Sorry I'm so lazy about that one.  The "can't open individual sites page" has
> got me lazy exercising the list page.  I'll do better.

I know, anything impacting the sites page can't be tested if you're running in the cloud :(. Bug 369433 is a technical limitation caused by the crummy way in which server responses from the "outer" server are rewritten when you're selfhosting. I'll try to devise a workaround over there that will permit the sites page to work.
Comment 3 Susan McCourt CLA 2012-02-03 12:52:25 EST
fixed (I'm fairly sure).
for some reason I had an old empty site config that it did let me open in a self hosting site editor.  I couldn't do anything with it (save, start, etc.) but I could see the commands not working.

The problem was in the way the editor was declaring commands, and when I tried to clean up the pages to "follow the rules" in order to get common styling, I missed this case.

- something that is to be a command on a random item in a list needs to be added as an "object" command
- something to be rendered in a specific place needs to be added as a "dom" command
- many pages use both (like nav which uses many of the same commands for root vs. members of the tree)

The site editor was only registering "object" commands.
I changed it to register "dom" commands where needed and to use "dom" based contributions in the glue code.

I can see the commands running now, but I can't verify that they actually do the right thing until I try in a build or localhost