Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 370498 - Update Generator UI to indicate which extensions have been applied to the workspace
Summary: Update Generator UI to indicate which extensions have been applied to the wor...
Status: REOPENED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: pf yu CLA
QA Contact:
URL:
Whiteboard: Extensibility_Gen
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-02 16:37 EST by Brian Svihovec CLA
Modified: 2017-02-23 14:19 EST (History)
5 users (show)

See Also:


Attachments
fix (11.30 KB, text/plain)
2012-02-07 04:28 EST, Huo Zhen Zhong CLA
huozz: iplog+
Details
screen shot (99.96 KB, image/jpeg)
2012-02-07 04:31 EST, Huo Zhen Zhong CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Svihovec CLA 2012-02-02 16:37:07 EST
As part of 369139, the EDT Generator framework was modified to support extensions to existing generators using the Eclipse plug-in framework.  

The EDT generator preference (EGL->Compiler->EDT)/properties pages should be updated to show a read only list of extensions that have been found for an existing generator.  

One option may be to expand the Generator tab at the bottom of these screens to include the read only list.
Comment 1 Brian Svihovec CLA 2012-02-02 16:38:20 EST
I have marked this as I2, but I think it can be implemented in I3 if necessary.  I think we want to implement this in the .8 release so that users can easily see what extensions have been added (i.e. IBMi).
Comment 2 Huo Zhen Zhong CLA 2012-02-07 04:28:55 EST
Created attachment 210630 [details]
fix
Comment 3 Huo Zhen Zhong CLA 2012-02-07 04:29:38 EST
Hi, Brian
Please help to review the implementation. Thanks
Comment 4 Huo Zhen Zhong CLA 2012-02-07 04:31:28 EST
Created attachment 210631 [details]
screen shot
Comment 5 Jeff Douglas CLA 2012-02-07 07:19:22 EST
I have a couple of questions:

1) does the list allow for multiple entries to be presented, because there can be many contributors for a specific provider

2) does the list also scan the "requires" settings, and bring in all of the contributors for the required ids as well

for example:

If a user created their own generator, that extended JavaGen, then they would need to create the extension point for their contributor, and that new contributor would have to include the requires id of JavaGenerationContributor as well. This means that their entire list to be displayed in the UI, would include all contributors for their extension PLUS all contributors for JavaHen, etc.
Comment 6 Huo Zhen Zhong CLA 2012-02-08 02:59:51 EST
Hi Jeff,
For 1), yes, it can support multiple entries
For 2), I use AbstractGenerator.determineContributions(id, contributionsUsed); method you have provide to get the contributors, I find that in the implementation of the method, you have scan the "requires" settings, and bring in all of the
contributors for the required ids as well

If no more question, I will check in the code tomorrow.
Comment 7 Huo Zhen Zhong CLA 2012-02-09 01:47:24 EST
finished
Comment 8 Brian Svihovec CLA 2012-02-15 12:45:13 EST
After reviewing the FVT scenario for this line item, I believe we may need to update the UI.  In the current screen capture, there are 3 columns for a Contributor:

* id
* class
* provider

While these accurately represent the information in the contributor extension point, I'm not sure a user will need to know any of this information.  

I would think that the ID should be replaced with a human readable Name, which would need to be provided in the extension point.

I'm not sure the class name is useful?

I believe the Provider basically duplicates the information in the selected tab (i.e. The Java Generator tab's provider shows as "org.eclipse.edt.ide.gen.JavaGenProvider")?

In general, I think a user should be able to select a generator and see a list of named contributions, and possibly a version number.  I realize that the extension point doesn't have a name or version number right now, but we may need to add these.  We may be able to use the version number from the contributions plug-in.
Comment 9 Huo Zhen Zhong CLA 2012-02-16 02:52:47 EST
Reopen this enhance base on comment 8, need to change the display contributor info to: 
* name
* version
These info need Jeff to add these extension feilds to let user to input.
Comment 10 Brian Svihovec CLA 2012-02-16 09:17:33 EST
This issue will require more discussion between Tim and Will before any changes can be made.  We may decide to hide this UI addition in .8 I2 and revisit this in I3.  More information will be posted soon.
Comment 11 Huo Zhen Zhong CLA 2012-02-16 22:25:44 EST
Have hide this in I2 and plan it to I3 after Tim and Will has made decision
Comment 12 Huo Zhen Zhong CLA 2012-02-24 01:46:26 EST
Hi, Tim and Will, Please make a quick decision so that I can finish it in I3
Comment 13 Brian Svihovec CLA 2012-02-27 10:01:10 EST
While we are making good progress on our extensibility design for EDT, I don't think we have reviewed the core design in enough detail to determine what the UI should look like at this time.  I think we should move this work item to the Future list, and we can revisit this work in the next release.
Comment 14 Huo Zhen Zhong CLA 2012-02-28 03:27:11 EST
set the target date to future base on Comment 13
Comment 15 Matt Heitz CLA 2013-01-03 14:21:32 EST
Setting the Target Milestone correctly for all bugs (set to Future in this case).