Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 370486 - R4E should be able to re-start after eclipse exit abnormally
Summary: R4E should be able to re-start after eclipse exit abnormally
Status: CLOSED MOVED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
: 375573 392482 (view as bug list)
Depends on:
Blocks: 399542
  Show dependency tree
 
Reported: 2012-02-02 14:41 EST by Jacques Bouthillier CLA
Modified: 2013-01-30 14:58 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jacques Bouthillier CLA 2012-02-02 14:41:15 EST 
When for any reason eclipse exit not normally, R4E does not work fine after the restart:
Scenario:
    - Open a review
    - Enter an anomaly
    --> Eclipse crash, so the file ( lmcbout_comments.xrer.lck ) has been created but never deleted

Now, restart eclipse, 
    - Open the review
    Try to enter a comment for the anomaly
Generates the following two errors:

1- 

org.eclipse.mylyn.reviews.r4e.core.model.serial.impl.ResourceHandlingException: The Resource is locked: R:\lmcalvs\shared\Reviews\r4e_0_2.3\Bug_149\lmcbout_comments.xrer.lck
Lock Information:
user: lmcbout
Date: Thu Jan 26 10:43:15 EST 2012

 at org.eclipse.mylyn.reviews.r4e.core.model.serial.impl.ChangeResController.lockResource(ChangeResController.java:248)
 at org.eclipse.mylyn.reviews.r4e.core.model.serial.impl.ChangeResController.checkOut(ChangeResController.java:121)
 at org.eclipse.mylyn.reviews.r4e.ui.internal.model.R4EUIAnomalyBasic.createChildren(R4EUIAnomalyBasic.java:395)
 at org.eclipse.mylyn.reviews.r4e.ui.internal.commands.NewChildElementHandler$1.runInUIThread(NewChildElementHandler.java:89)
 at org.eclipse.ui.progress.UIJob$1.run(UIJob.java:95)
 at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
 at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135)
 at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4140)
 at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3757)
 at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2696)
 at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2660)
 at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2494)
 at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:674)

2- 

java.lang.ArrayIndexOutOfBoundsException: -1
 at java.util.ArrayList.get(Unknown Source)
 at org.eclipse.mylyn.reviews.r4e.ui.internal.model.R4EUIAnomalyBasic.removeChildren(R4EUIAnomalyBasic.java:454)
 at org.eclipse.mylyn.reviews.r4e.ui.internal.commands.NewChildElementHandler$1.runInUIThread(NewChildElementHandler.java:96)
 at org.eclipse.ui.progress.UIJob$1.run(UIJob.java:95)
 at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
 at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135)
 at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:4140)
 at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3757)
 at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2696)
Comment 1 Jacques Bouthillier CLA 2012-04-04 09:59:12 EDT 
See also bug 372756
Comment 2 Sebastien Dubois CLA 2013-01-28 12:03:47 EST 
Some robustness improvements were already made.  This is linked to the fact that the lck file might stay there when Eclipse exits abnormally
Comment 3 Sebastien Dubois CLA 2013-01-28 16:12:23 EST 
*** Bug 392482 has been marked as a duplicate of this bug. ***
Comment 4 Sebastien Dubois CLA 2013-01-30 14:58:12 EST 
*** Bug 375573 has been marked as a duplicate of this bug. ***
Comment 5 Eclipse Webmaster CLA 2022-11-15 11:45:08 EST 
Mylyn has been restructured, and our issue tracking has moved to GitHub [1].

We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub.

[1] https://github.com/orgs/eclipse-mylyn