Comment 1 Frank Becker 2012-02-02 16:00:17 EST

review http://review.mylyn.org/241 created!

Comment 2 Frank Becker 2012-02-02 16:00:19 EST

Created attachment 210474 [details]
mylyn/context/zip

Comment 3 Steffen Pingel 2012-02-02 17:41:30 EST

I commented on the review.

Comment 4 Frank Becker 2012-02-04 06:06:23 EST

Steffen,

I commented on the review and now install and setup  Eclipse 3.4.2, 3.5.2, and 3.6.2 so that I can test this

Comment 5 Steffen Pingel 2012-02-04 06:40:20 EST

An easy way to switch between the different platforms is to use targets. I have defined a few for Mylyn that you select in the preferences under Target Platform if you have the org.eclipse.mylyn-targets project checked out in your workspace.

Comment 6 Steffen Pingel 2012-02-04 06:55:54 EST

On a related note, we should at some point look at the critical FindBugs violations. Some might be worth fixing: http://mylyn.org/sonar/drilldown/violations/org.eclipse.mylyn.tasks:org.eclipse.mylyn.tasks-parent?severity=CRITICAL

Comment 7 Frank Becker 2012-02-04 09:26:59 EST

Steffen,

I create an new patchset.

I can not switch to the target mylyn-e3.4.target because I get more then 1000 errors.

For http://mylyn.org/sonar I get no data

Comment 8 Steffen Pingel 2012-02-04 10:25:54 EST

Thanks. The latest patch set looks good to me.

(In reply to comment #7)
> I can not switch to the target mylyn-e3.4.target because I get more then 1000
> errors.

Don't worry about 3.4 support. The reference for warnings should be 3.8 but we need to ensure that we maintain backwards compatibility.

> For http://mylyn.org/sonar I get no data

I have restarted the server, should be back up now.

Comment 9 Frank Becker 2012-02-04 11:36:20 EST

We now have only 6 Java Problems and 1 Plug-in Problem

Comment 10 Steffen Pingel 2012-02-05 06:08:10 EST

This change caused a compile error on 3.6 and earlier:  http://ci.mylyn.org/job/mylyn-3.7.x/72/

[ERROR] /home/hudson/.hudson/jobs/mylyn-3.7.x/workspace/TARGET/helios/org.eclipse.mylyn.tasks/org.eclipse.mylyn.tasks.ui/src/org/eclipse/mylyn/internal/tasks/ui/TasksUiPlugin.java (at line 1387):[-1,-1]
[ERROR] identityServiceTracker = new ServiceTracker<Object, Object>(getBundle().getBundleContext(),
[ERROR] ^^^^^^^^^^^^^^
[ERROR] The type ServiceTracker is not generic; it cannot be parameterized with arguments <Object, Object>
[ERROR] -> [Help 1]

I have pushed a fix.