Community
Participate
Working Groups
Per bug 360986, we will rarely use icons in the toolbars and slideouts. Only special purpose controls/navigations will be used. We will want these to be a different style than the yellow. Here is the working list: - close (X). For the slideout and for closing the notification messages that appear in the slideout. Not yellow. - OK/Submit (check mark). For the slideout. Not yellow. - More (...) for the slideout. Not yellow. - Favorite icon in banner?? Not yellow??? - Navigation arrows - up, down, left, right. These arrows will be used in toolbars when an arrow makes more sense than words (next search result, etc.). Need non yellow versions. - Operations running animated icon (we are currently using the eclipse one, might be good enough) - Operations none. A button to open the current operations list when none are running. - Operation ended in error. - Operation ended in warning. - help (this may go in the user menu so not sure yet it's needed. See bug 367784)
need a polished/centered sep.gif
Pairing down the list after meeting with Linda. We've looked at the current implementation and concluded: - the arrow icons in yellow are looking fine - we will use text in the slideout for OK/Submit and More rather than icons - we need better error/warning/info slideout icons than the old eclipse ones that we are using. So the working list of icons is now: - close (X) - Favorite icon (Star, but muted for banner, not yellow) - error (for notification slideout) - warning (for notification slideout) - info (for notification slideout) - progress (for notification slideout) - operations running animated icon Re: operations none, progress/info, progress/warning, progress/error. I'm not convinced these are necessary. Opened bug 370782.
we've received everything except the busy icons.
- the favorites icon for the banner seems too small. - also need to tweak the style so it gets the consistent hover that buttons get
remote branch origin/iconsprites04RC3 contains the last set of icons from the graphic designers: - git active branch - the new, cool, groovy "busy" icon - a small menu twistie for dojo menus (so that the double chevron is only used for menus with no text at all) Changes to source: - replaced various icon files, added new ones - commands.css - change default dojo menu twistie and add "textless" style for chevron - ide.css - change busy icons and add margin so they aren't butted up against the top of the toolbar - commands.js - use "textless" to get chevron on textless menu - commonHTMLFragments.js - use "textless" to get chevron on user menu - textSearcher.js - switch command definitions from using image files to using css sprite classes (that were already there). This prevents an image loading race condition that was sometimes causing the find/replace slideout to flicker/change size Observed improvements: - Related pages has a small twistie, not the honking chevron - Orion busy icon, better positioning in toolbar - Find/replace dialog, no "resize bump" in image loading
commit SHA is 2b53d738c20727fefbe6dacd780986f35588e49c (if you prefer open commit vs. going to the log)
As a project lead I +1 this for RC3
Created attachment 211369 [details] pic The only possible issue I saw is that the mini-chevron appears somewhat smushed against the right-hand border when you hover over a dropdown. This was not the case with the old honking big chevron
pushed fix.
(In reply to comment #8) > The only possible issue I saw is that the mini-chevron appears somewhat smushed > against the right-hand border when you hover over a dropdown. This was not the > case with the old honking big chevron I fixed this in the spriting class. The dojo image overrides require a little hand-crafting anyway so I added a margin around the little twistie.
(In reply to comment #10) > (In reply to comment #8) > > > The only possible issue I saw is that the mini-chevron appears somewhat smushed > > against the right-hand border when you hover over a dropdown. This was not the > > case with the old honking big chevron > > I fixed this in the spriting class. The dojo image overrides require a little > hand-crafting anyway so I added a margin around the little twistie. in the spriting *pass* (not class). The margin for the small twistie gets added in bug 371262. Thanks, Mark.
