Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 370471 - Double-clicking on marker category crashes Eclipse
Summary: Double-clicking on marker category crashes Eclipse
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.8   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.2 M6   Edit
Assignee: Eric Moffatt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-02 12:36 EST by Michael Rennie CLA
Modified: 2012-03-13 10:19 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rennie CLA 2012-02-02 12:36:57 EST 
Version: 4.2.0 (happens in 3.x as well)
Build id: I20120126-1300

Steps:

1. select a lot of projects in your workspace
2. open the Problems view and group the markers by 'Java Problem Type'
3. double-click a category with a lot of markers in it to expand it
4. realize that double-clicking does not expand, but instead opens all child markers in editors
5. watch patiently as 100's (or 1000's) of editors are opened and Eclipse dies a slow death-by-editor.
Comment 1 Michael Rennie CLA 2012-02-02 12:48:40 EST 
I created a github branch for this bug: https://github.com/mrennie/eclipse.platform.ui/tree/mrennie/bug/370471

I removed the code that collects all child markers from categories during the open operation and added a double click listener to the viewer to expand expandable items.
Comment 2 Eric Moffatt CLA 2012-02-07 13:27:02 EST 
Pushed (on behalf of Mike) in >20120207.

commit 6ad021ae58321f88d72697669b5eacde990f54a8

Mike, there was what seems to be a spurious change to BrowserViewer in this change set, was this intentional ? I've left the change in the commit since it was just a remove of an unnecessary import.
Comment 3 Paul Webster CLA 2012-02-08 07:34:23 EST 
Don't forget to cherrypick the changes back into R3_development

http://dev.eclipse.org/mhonarc/lists/e4-dev/msg06265.html

PW
Comment 4 Michael Rennie CLA 2012-02-08 10:27:10 EST 
(In reply to comment #2)
> Pushed (on behalf of Mike) in >20120207.
> 
> commit 6ad021ae58321f88d72697669b5eacde990f54a8
> 
> Mike, there was what seems to be a spurious change to BrowserViewer in this
> change set, was this intentional ? I've left the change in the commit since it
> was just a remove of an unnecessary import.

It was intentional. I was tired of seeing the error in my workspace :)
Comment 5 Eric Moffatt CLA 2012-02-28 15:06:15 EST 
Paul, I just tried to do the cherry pick and it says that it's already there...

I think it was this one..

commit e22e6142750f84f2536ec116061307b26810f231

Could you check to make sure...thanks (the code certainly looks ok in R3_development)
Comment 6 Paul Webster CLA 2012-02-28 15:09:34 EST 
(In reply to comment #5)
> Paul, I just tried to do the cherry pick and it says that it's already there...
> 
> I think it was this one..
> 
> commit e22e6142750f84f2536ec116061307b26810f231

Yes, that's it, and it looks fine.

PW
Comment 7 Paul Webster CLA 2012-03-13 10:19:54 EDT 
In I20120312-1800

PW