Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 370460 - Refactor git client to unify the way of calling functions.
Summary: Refactor git client to unify the way of calling functions.
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Git (show other bugs)
Version: 0.4   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 2.0 M2   Edit
Assignee: Malgorzata Janczarska CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-02 11:07 EST by Malgorzata Janczarska CLA
Modified: 2013-01-21 05:05 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Malgorzata Janczarska CLA 2012-02-02 11:07:56 EST 
gitClient contains methods that are called in at least 4 ways:
* response is retrieved via returned promise
* response is retrieved via onLoad function
* response is retrieved via onLoad event (I think not used anywhere)
* we return errors in onError or just in the promise
Some of the functions also modify the response it gets from a server wrapping it with some json object (doMerge). I really think we should unify it all and beginning of 0.5 will be a good time to do it.
Comment 1 Malgorzata Janczarska CLA 2012-04-12 13:14:14 EDT 
(In reply to comment #0)
> gitClient contains methods that are called in at least 4 ways:
> * response is retrieved via returned promise
> * response is retrieved via onLoad function
> * response is retrieved via onLoad event (I think not used anywhere)
> * we return errors in onError or just in the promise
This is done by Bug 376104.

> Some of the functions also modify the response it gets from a server wrapping it
> with some json object (doMerge). I really think we should unify it all and
> beginning of 0.5 will be a good time to do it.
This will be done in M2.
Comment 2 Malgorzata Janczarska CLA 2013-01-21 05:05:43 EST 
Resolved while refactoring git client for new operations.