Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 370440 - Over scaling of connections and lines after canvas zoom
Summary: Over scaling of connections and lines after canvas zoom
Status: CLOSED FIXED
Alias: None
Product: Graphiti
Classification: Modeling
Component: Core (show other bugs)
Version: 0.8.0   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 0.9.0   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard: Juno M7 Theme_bugs
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-02 09:25 EST by Craig Petre CLA
Modified: 2012-06-29 04:24 EDT (History)
7 users (show)

See Also:
christian.brand: juno+


Attachments
100% Zoom (3.38 KB, image/png)
2012-02-02 09:25 EST, Craig Petre CLA
no flags Details
400% Zoom (10.74 KB, image/png)
2012-02-02 09:26 EST, Craig Petre CLA
no flags Details
800% Zoom (16.46 KB, image/png)
2012-02-02 09:26 EST, Craig Petre CLA
no flags Details
Actor - 100% Zoom (16.02 KB, image/jpeg)
2012-04-06 16:10 EDT, Steffen K. CLA
no flags Details
Actor (overscaled line width) - 400% Zoom (45.38 KB, image/jpeg)
2012-04-06 16:12 EDT, Steffen K. CLA
no flags Details
Use Case - 100% Zoom (14.72 KB, image/jpeg)
2012-04-06 16:12 EDT, Steffen K. CLA
no flags Details
Use Case (cut off) - 400% Zoom (55.03 KB, image/jpeg)
2012-04-06 16:13 EDT, Steffen K. CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Craig Petre CLA 2012-02-02 09:25:11 EST
Build Identifier: 20110916-0149

Certain types of lines and connections appear to be scaling more than they should during zoom.  It seems the expected behavior during zoom is that the ratio of line width to grid block should remain consistent regardless of zoom level; however, this does not seem to be the case.  Attached are some screen shots from the sketch tool against nightly build: 0.9.0.v20120131-1644 of Graphiti which illustrate the bug.

Reproducible: Always

Steps to Reproduce:
1.  Drag a EClass into the diagram (or two and connect them)
2.  Take not of the line thickness (of borders/connections) as it relates to the grid
3.  Zoom in (400% or so) and notice the line thickness is much greater with respect to the grid as it was in the 100% zoom case.  Zoom to 1000% to notice the effects even more.
Comment 1 Craig Petre CLA 2012-02-02 09:25:55 EST
Created attachment 210448 [details]
100% Zoom
Comment 2 Craig Petre CLA 2012-02-02 09:26:29 EST
Created attachment 210449 [details]
400% Zoom
Comment 3 Craig Petre CLA 2012-02-02 09:26:59 EST
Created attachment 210450 [details]
800% Zoom
Comment 4 Steffen K. CLA 2012-04-06 16:10:33 EDT
Created attachment 213714 [details]
Actor - 100% Zoom

UML Actor - Zoom 100%
Comment 5 Steffen K. CLA 2012-04-06 16:12:06 EDT
Created attachment 213715 [details]
Actor (overscaled line width) - 400% Zoom
Comment 6 Steffen K. CLA 2012-04-06 16:12:40 EDT
Created attachment 213716 [details]
Use Case - 100% Zoom
Comment 7 Steffen K. CLA 2012-04-06 16:13:21 EDT
Created attachment 213717 [details]
Use Case (cut off) - 400% Zoom
Comment 8 Steffen K. CLA 2012-04-06 16:13:56 EDT
We from the Spray project have the same problems with the scaling during zoom as described above. Additionally we noticed that during zoom some parts of our graphics get cut off (see attachment Use Case (Cut Off) - 400% Zoom). Also the line width of our graphics get overscaled during zoom (see attachments Actor 100% and Actor 400%).

The possibility to zoom into diagrams is very important for our project and we would be grateful if you could solve this problem.
Comment 9 Michael Wenz CLA 2012-04-10 02:10:23 EDT
(In reply to comment #8)
> The possibility to zoom into diagrams is very important for our project and we
> would be grateful if you could solve this problem.

Actually, a colleague had a look into this issue the week before easter. We only talked shortly on this, but he mentioned some (maybe missing) GEF (?) functionality. The colleague is not in the office this week, so let's see were we can get with this after his vacation.
Comment 10 Christian Brand CLA 2012-04-24 02:21:10 EDT
The problem with overscaling line widths should be solved now. We had some intensive tests and everything looked well.
The mentioned problem with shapes which are cut off in zoom mode has to be handled separately. So we have to open up a new bug. With some investigations in that direction it must be feared that the correction opens a big construction site... So perhaps we cannot solve it for this release.
Comment 11 Christian Brand CLA 2012-04-24 02:40:31 EDT
commit a8f1211e8cc5046d47eb4b499d827cc285bb7242
Author: cbrand <christian.brand@sap.com> 2012-04-20 14:58:05
Committer: cbrand <christian.brand@sap.com> 2012-04-20 14:58:05
Parent: eb5f77b24660a3d8239db0b9bcbb1fbccf245f57 (Bug 369241 - SVG export does not rotate objects)
Branches: origin/master
Comment 12 Matthias Gorning CLA 2012-04-24 03:00:16 EDT
Existing problems will be solved in the Kepler release:

See https://bugs.eclipse.org/bugs/show_bug.cgi?id=377465
Comment 13 Michael Wenz CLA 2012-06-29 04:24:06 EDT
Part of Graphiti 0.9.0 (Eclipse Juno)