Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 370384 - jetty-distribution is dependent on jetty-all aggregate?
Summary: jetty-distribution is dependent on jetty-all aggregate?
Status: CLOSED FIXED
Alias: None
Product: Jetty
Classification: RT
Component: server (show other bugs)
Version: 8.1.0   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 7.5.x   Edit
Assignee: Jesse McConnell CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-01 20:26 EST by Greg Wilkins CLA
Modified: 2013-01-28 13:45 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Greg Wilkins CLA 2012-02-01 20:26:08 EST
The jetty-distribution is dependent on the jetty-all aggregate.  This should not be the case because the aggregates are really just other distributions (and I'd really like to remove them from the normal build).

More importantly, the jetty-all javadoc jar is ending up in the distro lib directory, which is just 4.5MB of unused data.   This at least has to be fixed ASAP.
Comment 1 Joakim Erdfelt CLA 2012-02-01 20:30:59 EST
Javadoc was added to the distribution back on Sept 16th, 2011
It's been present in the distribution since jetty 7.5.2
Comment 2 Joakim Erdfelt CLA 2012-02-01 20:36:38 EST
Commit'd change to exclude jetty-all from lib directory.

As for the dependency on jetty-all for its javadoc, that would result in generating javadoc 3 times (currently 2 times).  Is this wise?
Comment 3 Greg Wilkins CLA 2012-12-12 16:34:50 EST
The javadoc is no longer in the lib directory, but it is being brought in from jetty-all to the correct location.

One potential fix is to have a jetty-javadoc module that builds the combined javadoc for all of jetty, and then this is consumed by both jetty-distribution and jetty-all.

or we can just leave it as it is for now.

The main thing to avoid is building all the javadoc twice.
Comment 4 Jesse McConnell CLA 2012-12-14 16:39:46 EST
a lot of the current mechanism was to work around issues related to the javadoc plugin in the first place so I'll have a look see to check if that has been fixed up and if so work out a better mechanism for this

it would be grand if we could have a separate module that built and contained an complete javadoc and xref artifacts which could be pulled into the distribution/deployed to downloads.eclipse.org/jetty