Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 370353 - Line numbers for source in Git web interface are misaligned
Summary: Line numbers for source in Git web interface are misaligned
Status: RESOLVED FIXED
Alias: None
Product: Community
Classification: Eclipse Foundation
Component: Git (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Eclipse Webmaster CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-02-01 12:03 EST by Markus Keller CLA
Modified: 2012-02-01 15:14 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2012-02-01 12:03:13 EST 
The line numbers for source in the Git web interface are misaligned:

http://git.eclipse.org/c/equinox/rt.equinox.p2.git/tree/bundles/org.eclipse.equinox.p2.tests/src/org/eclipse/equinox/p2/tests/artifact/processors/Pack200ProcessorTest.java

The problem is in
http://git.eclipse.org/eclipse.org-common/themes/Nova/css/visual.css :

The

    a {[..]	font-weight: bold; [..]}

not only makes the links wider but also taller. When I remove that property in Firebug, then the line numbers are fine again.
Comment 1 Markus Keller CLA 2012-02-01 12:24:10 EST 
To avoid changing the whole world, an easy fix is to add

    font-weight: normal;

to "table.blob a.no" in http://git.eclipse.org/cgit.css
Comment 2 Denis Roy CLA 2012-02-01 13:57:39 EST 
^^ Awesome.  I've added that to cgit.css.  Please give it a try.
Comment 3 Markus Keller CLA 2012-02-01 15:14:35 EST 
Looks good, thx.