Comment 1 Thomas Watson 2012-02-01 08:55:53 EST

Some of these failures are related to bug361628 I think.

Comment 2 Meng Xin Zhu 2012-02-01 22:27:24 EST

(In reply to comment #1)
> Some of these failures are related to bug361628 I think.
A failure is caused by the unpredicated execution order of test methods. The test case still can be improved to make sure its dependency.

Comment 3 Meng Xin Zhu 2012-02-02 00:51:22 EST

Submitted. http://git.eclipse.org/c/equinox/rt.equinox.p2.git/commit/?id=01a38934f837fbe013193d4324a8def5d2f0d292

Comment 4 Dani Megert 2012-02-06 02:53:57 EST

(In reply to comment #0)
> Test case 'testConfigureUndoEvent' and 'testCollectEvent' failed on latest
> integration build. See test result[1].

Verified that those two are fixed in N20120203-2000.

Reopening as there are still 5 remaining tests:

http://download.eclipse.org/eclipse/downloads/drops/N20120203-2000/testresults/html/org.eclipse.equinox.p2.tests_win32.win32.x86_7.0.html

Please close again if it is confirmed that they are all caused by bug 361628.

Comment 5 Dani Megert 2012-02-06 02:54:06 EST

.

Comment 6 Ian Bull 2012-02-06 10:58:41 EST

(In reply to comment #4)
> Verified that those two are fixed in N20120203-2000.
> 
> Reopening as there are still 5 remaining tests:
> 
> http://download.eclipse.org/eclipse/downloads/drops/N20120203-2000/testresults/html/org.eclipse.equinox.p2.tests_win32.win32.x86_7.0.html
> 
> Please close again if it is confirmed that they are all caused by bug 361628.

Thanks Dani.

The last 3 appear to be problems with the test cases (related to testing read only installs).  The logic goes like this:

1. Set the directory to read-only
2. Assert that the directory is read-only

This fails.  

I'm not sure if this is a Java 7 thing, or something on the test machine.  I don't have a Java 7 windows machine myself, but I'll try to set one up on a VM.

Comment 7 Meng Xin Zhu 2012-02-06 22:50:18 EST

I had a look at it.

Those three test cases try to imitate the share install on Windows before running them. It makes the parent folder and all its files of Eclipse platform as read-only. Then use Java API File.canWrite() to check whether the files can be written in that given folder.

Windows is quite different on file permission management comparing to Linux. User still can create new files under the folder that is read-only. I tried Sun JDK 1.5u11, JDK 6u25 and JDK 7.0u2. Only 1.5u11 considers the read-only folder can't be written. However both 6u25 and 7u2 considers the read-only folder can be written, that's the true.

I guess those cases were designed on JDK5, however newer JDK has fixed this issue on Windows.

If we want those cases work well again, we must know how UAC(Vista and Win 7) works. The cases need on behavior of administrator user to create Eclipse platform firstly, then use normal user privilege to run shared install tests.

cc DJ who made last fix on shared install tests

Comment 8 Meng Xin Zhu 2012-04-28 03:27:06 EDT

Close this one. The failure of director test cases are related to this one.

Comment 9 Ian Bull 2012-06-05 23:00:21 EDT

Actually these specific tests are still failing, so I'm re-opening. I'm not sure these are related to the Nested Jars, but rather something to do with file permissions.

Comment 10 Meng Xin Zhu 2012-09-17 22:39:06 EDT

The failure has not happened for a while in 4.3 I-build. Close it.