Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 370287 - Wikitext link to task opens in browser
Summary: Wikitext link to task opens in browser
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 minor (vote)
Target Milestone: 1.6.0   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-31 19:05 EST by Sam Davis CLA
Modified: 2012-02-08 17:01 EST (History)
2 users (show)

See Also:

Attachments
mylyn/context/zip (27.29 KB, application/octet-stream)
2012-02-02 13:24 EST, David Green CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Davis CLA 2012-01-31 19:05:05 EST 
If you click, for example, "this link to a task":https://bugs.eclipse.org/bugs/show_bug.cgi?id=354302, it opens in a browser instead of the task editor.
Comment 1 Steffen Pingel CLA 2012-02-01 16:43:01 EST 
David, how does WikiText open URLs? With the changes for bug 346046 we could easily open URLs in the corresponding rich editors if BrowserUtil.openUrl() is used.
Comment 2 David Green CLA 2012-02-02 13:24:30 EST 
Wow, that makes things much easier.  I've pushed a change to Gerrit for review: http://review.mylyn.org/#change,240
Comment 3 David Green CLA 2012-02-02 13:24:47 EST 
Created attachment 210468 [details]
mylyn/context/zip
Comment 4 Steffen Pingel CLA 2012-02-02 17:36:58 EST 
The change looks good to me. Only consideration could be the dependency on Mylyn 3.7 that we removed some time ago. If it's okay to add that back we should also consider bug 365512.

I have opened bug 370504 to make the URL handler API work for tasks, currently it only works for links to Hudson builds and certain links to Gerrit reviews.
Comment 5 Steffen Pingel CLA 2012-02-02 18:02:18 EST 
On second thought, this should already work. Since WikiText is using the TasksUi.openUrl() method we should recognize those as task URLs already so this shouldn't require any changes in WikiText. I'll take a look why this isn't working.
Comment 6 Steffen Pingel CLA 2012-02-02 20:33:31 EST 
David, the easiest fix would be to change the call from TasksUiUtil.openUrl() to TasksUiUtil.openTask(). The latter will fallback to BrowserUtil.openUrl() if it's not a task URL and the API is also available on 3.6.
Comment 7 David Green CLA 2012-02-08 17:01:32 EST 
with bug 365512 implemented, this bug is fixed.

Thanks for your contribution Steffen.