Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 370218 - OpenResourceDialog has no error reporting
Summary: OpenResourceDialog has no error reporting
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.4   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.5 M2   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-31 09:39 EST by Mark Macdonald CLA
Modified: 2012-04-20 16:02 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Macdonald CLA 2012-01-31 09:39:09 EST 
Orion I20120130-2230

When a search query generates a server error, OpenResourceDialog just says "Searching..." forever. You never see the error.

1. Start a selfhosted site
2. Log in and press 't' in the Navigator to bring up the OpenResourceDialog.
3. From another tab, stop the selfhosted site.
4. Switch back to the tab with the OpenResourceDialog and try to search. It looks like it's working, but the queries are actually timing out.

I hit this bug whenever orion.eclipse.org is restarted.
Comment 1 John Arthorne CLA 2012-04-20 16:02:10 EDT 
I have added error reporting:

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=d8b3a787e576702bb4c68364e9345138eb0639c7

However the "not logged in" case is tough because the error doesn't propagate back to the caller. Instead you get the login prompt and the xhr call gets queued for a retry. After logging in the search completes. I think the login dialog popping up is good enough for this case.