Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 370163 - URL for resetting password is incorrect - works but spelled incorrectly
Summary: URL for resetting password is incorrect - works but spelled incorrectly
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Server (show other bugs)
Version: 0.4   Edit
Hardware: PC Mac OS X - Carbon (unsup.)
: P3 normal (vote)
Target Milestone: 0.4 RC1   Edit
Assignee: Ken Walker CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-30 15:53 EST by Ken Walker CLA
Modified: 2012-02-01 03:48 EST (History)
3 users (show)

See Also:
mamacdon: review+
malgorzata.tomczyk: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ken Walker CLA 2012-01-30 15:53:12 EST 
If you use the feature to reset your orion password the url link is spelled incorrectly:

passwrodResetId

It does work however because it is a constant on the server.
Comment 1 Ken Walker CLA 2012-01-30 15:54:39 EST 
Working on a fix
Comment 2 Ken Walker CLA 2012-01-30 16:22:54 EST 
Proposed fix is here:

https://github.com/kenwalker/orion.server/commit/f511e0b054b8173920390f0f8d8dccc8b554be25

I wrote all this code and have the rights to contribute it to Eclipse under the
eclipse.org web site terms of use.
Comment 3 Szymon Brandys CLA 2012-01-31 05:51:49 EST 
I guess Gosia can review the fix too.
Comment 4 Malgorzata Janczarska CLA 2012-01-31 06:19:32 EST 
(In reply to comment #3)
> I guess Gosia can review the fix too.

Fix is good. Nice catch BTW.
Comment 5 Malgorzata Janczarska CLA 2012-01-31 09:59:30 EST 
Mark, I can see you already pushed this commit to master. Does this mean that this can be closed?
Comment 6 Mark Macdonald CLA 2012-01-31 10:03:19 EST 
(In reply to comment #5)
> Mark, I can see you already pushed this commit to master. Does this mean that
> this can be closed?

Yes. Sorry for pushing before you reviewed it.

Also I forgot to set the +1 flag.