Community
Participate
Working Groups
The regular expression that attempts to extract the identity of the author or the committer is being thrown off by the presence of a period (.). e.g. "Author: Shawn O. Pearce <spearce@spearce.org>" is misparsed because of the dot following the O. The regular expression in use is probably a little more specific than it needs to be. '/Commit: ([\w ]+) <([^>]+)>/i' can be simplified to 'Commit:\s+(.*) <([^>]+)>'.
FWIW it seems this regexp may also prevent correct parsing of authors with dashes in their names. Commit [1] is attributed to simply "Marc" in Koneki IP log [1]: http://git.eclipse.org/c/koneki/org.eclipse.koneki.ldt.git/commit?id=992f54027cdbbe397a753f59b8f8a9f498ca4791 [2]: http://www.eclipse.org/projects/ip_log.php?projectid=technology.koneki
The dash in Marc's name was throwing off the regex. I've fixed and tested it; it appears to function correctly. Marking as FIXED.
May I ask for a small clarification? I removed the iplog+ flags for all the Koneki bugs whose commits were made in Marc-André's name, since they resulted in duplicated entries in the iplog. But now, the Contribution Review tool is complaining that I should have marked the attachments with iplog+. I am confused since [1] says there's no need to iplog+ Git contributions with author name set; but still I can see that other projects seem to flag iplog+ and yet don't have duplicated entries in their IP logs. Thanks! [1] http://wiki.eclipse.org/Development_Resources/Handling_Git_Contributions
(In reply to comment #3) > May I ask for a small clarification? > I removed the iplog+ flags for all the Koneki bugs whose commits were made in > Marc-André's name, since they resulted in duplicated entries in the iplog. But > now, the Contribution Review tool is complaining that I should have marked the > attachments with iplog+. > > I am confused since [1] says there's no need to iplog+ Git contributions with > author name set; but still I can see that other projects seem to flag iplog+ > and yet don't have duplicated entries in their IP logs. > Thanks! > > > [1] http://wiki.eclipse.org/Development_Resources/Handling_Git_Contributions Sorry, this is point-in-time confusion. The contribution tool only considers Bugzilla data; when it was made, Bugzilla was the sole source of contribution information. The tool needs to be updated to account for Git-based contributions. Unfortunately, I'm not sure how clever we can be in this regard. The only fix that I can think of right now is to add some text to the page describing the purpose of tool (to mark contributions that are made through Bugzilla and not tracked by Git) and its limitations.
(In reply to comment #4) > Sorry, this is point-in-time confusion. The contribution tool only considers > Bugzilla data; when it was made, Bugzilla was the sole source of contribution > information. The tool needs to be updated to account for Git-based > contributions. I've opened Bug 372680 to track this update requirement.
